Workaround for errors sent improperly to stdout by prettier_d#39
Workaround for errors sent improperly to stdout by prettier_d#39matthugs wants to merge 1 commit into
Conversation
From this it should be simple to use `prettier_d` as a drop-in replacement by customizing the `prettier-js-command` custom variable. fixes prettier#34
8c78d43 to
0f67890
Compare
|
Thanks for submitting this back when you did! Unfortunately I feel like this contribution has gone stale.
I tried the changes suggested in this PR with the alternative package: https://github.com/mikew/prettier_d_slim Indeed, these changes did un-swallow errors from With globally-installed
|
|
If folks are unsatisfied with the performance of running the Personally, I do not find the overhead of calling |
|
I experimented with This daemon doesn't throw errors, so it's usable. It also writes its errors to stdout, so the suggested change could be useful if people wanted to use it. However, when experimenting with this implementation, right away I found myself fussing with manual process management, confirming my fears about bad DX associated with daemon usage. I find that this daemon implementation requires a manual restart via the terminal when it gets into an error state (e.g. malformed config). Also, when you run That said, I don't want to deny people the opportunity to use and customize this package how they like, especially considering this is a minor change. I'll recreate this PR with support for |
|
Recreated here: #91 |
From this it should be simple to use
prettier_das a drop-inreplacement by customizing the
prettier-js-commandcustom variable.fixes #34