fix(sniffs): allow Helper classes in Service/ directory#55
Merged
Conversation
ServiceStructureSniff incorrectly flagged Helper and Factory classes inside
Service/ directory as violations. Per conventions:
- core-patterns/helper.md: Infrastructure/Service/{Context}/Helper/{Name}Helper
- core-patterns/factory.md: Application/Service/{ServiceName}/{Name}Factory
Added early return in assertCompanionClassAllowed for classes with Helper
and Factory suffixes.
prikotov
force-pushed
the
task/allow-helpers-in-service-dir
branch
from
3655fb3 to
5b50217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
ServiceStructureSniffошибочно ругался на Helper-классы внутриService/директории. По конвенции (core-patterns/helper.md) хелперы явно разрешены по пути:Это заставляло AI-агентов выкидывать
Service\из пути вместо исправления именования — тот же паттерн обхода, что и сNullNotificationBroadcaster.Решение
В
assertCompanionClassAllowedдобавлен ранний возврат для классов с суффиксомHelper.Тест
RutubeHelper.inc— Helper вInfrastructure\Service\...\Helper\→ проходитЧек-лист
composer checkпройден