docs(conventions): fix Domain DTO location — must be inside Service context#57
Merged
Conversation
prikotov
force-pushed
the
task/fix-domain-dto-path
branch
4 times, most recently
from
0cb44c2 to
322d777
Compare
- DtoStructureSniff: error when Domain DTO is in Domain/Dto/ instead of
Domain/Service/{ServiceName}/
- ServiceStructureSniff: allow classes with Dto suffix in Service/ directory
(already allowed: Helper, Factory)
- Added todo task for path validation of other layers (Application,
Infrastructure, Integration, Presentation)
prikotov
force-pushed
the
task/fix-domain-dto-path
branch
from
322d777 to
faf2960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Конвенция DTO разрешала
Domain\Dto\{Name}Dto— это подразумевало общие доменные DTO, что неверно. DTO в Domain всегда привязан к конкретному сервису.Решение
Путь исправлен на
Domain\Service\{ServiceName}\{Name}Dto— в соответствии с примером в конвенции Service (Domain\Service\FxRate\FxRateDto).Чек-лист
composer checkпройден