feat(sniffs): allow Mapper classes in Service/ directory#58
Merged
Conversation
prikotov
force-pushed
the
task/allow-mapper-in-service-dir
branch
from
662cd71 to
af27a6b
Compare
- ServiceStructureSniff: add Mapper to allowed suffixes (Helper, Factory, Dto, Mapper)
- mapper.md convention:
- add Domain/Service/{ServiceName}/{Name}Mapper path
- add Infrastructure/Service/{ServiceName}/{Name}Mapper path
- remove extra Mapper/ subdirectory from Component and Service paths
(mapper sits directly next to service, not in a Mapper/ subfolder)
prikotov
force-pushed
the
task/allow-mapper-in-service-dir
branch
from
af27a6b to
af66b33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
ServiceStructureSniffругался на Mapper-классы внутриService/—Mapperне был в списке разрешённых суффиксов. Агент выносил Mapper изService/вместо добавления исключения.Решение
Mapperдобавлен в$allowedSuffixes(Helper,Factory,Dto,Mapper)Infrastructure/Service/{ServiceName}/Mapper/{Name}MapperЧек-лист
composer checkпройденSessionPayloadMapper.incдобавлена