This repository was archived by the owner on Jun 28, 2026. It is now read-only.
fix: unused zIndexes on element update#217
Open
floriegl wants to merge 1 commit into
Open
Conversation
4 tasks
floriegl
marked this pull request as ready for review
January 22, 2026 01:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes primefaces/primevue#8393
If an element, which wants to
seta new zIndex, I see no reason to not remove it from thezIndexes. This behavior makes sense for example in the PrimeVue toast component, as it should increase its zIndex if new messages get added (move in front of a dialog, if the dialog triggers toast messages while open), but not leave any unused ones behind in thezIndexes.