This repository was archived by the owner on Jul 7, 2025. It is now read-only.
Draft
Conversation
ericwbailey
approved these changes
Jul 10, 2023
Contributor
ericwbailey
left a comment
ericwbailey
left a comment
There was a problem hiding this comment.
A couple of tiny nits, but nothing that would get in the way of merging. Awesome stuff!
|
|
||
| {/* ![Video of DataTable with row selection. The first 3 rows are selected, and the select-all checkbox is in an indeterminate state. The header changes to show the batch row actions when one or more rows are selected.]() */} | ||
|
|
||
| A data table component can support the ability to have one or more rows selected. A batch of selected rows can then have actions applied to them. |
Contributor
There was a problem hiding this comment.
Suggested change
| A data table component can support the ability to have one or more rows selected. A batch of selected rows can then have actions applied to them. | |
| A DataTable component can support the ability to have one or more rows selected. A batch of selected rows can then have actions applied to them. |
Comment on lines
+572
to
+573
| If the data table is paginated, the "Select all rows" checkbox is activated, all rows on the currently displayed page are selected. Rows on pages that are not the currently displayed will **not** be selected. | ||
| For example, consider a paginated data table that displays 25 rows per page, with a total of 400 rows in the table. All rows on the current page are selected by the user. Deleting the selected rows should remove only the displayed rows, as to avoid unintentionally applying a destructive act to the other 375 rows. |
Contributor
There was a problem hiding this comment.
Suggested change
| If the data table is paginated, the "Select all rows" checkbox is activated, all rows on the currently displayed page are selected. Rows on pages that are not the currently displayed will **not** be selected. | |
| For example, consider a paginated data table that displays 25 rows per page, with a total of 400 rows in the table. All rows on the current page are selected by the user. Deleting the selected rows should remove only the displayed rows, as to avoid unintentionally applying a destructive act to the other 375 rows. | |
| If the DataTable is paginated, the "Select all rows" checkbox is activated, all rows on the currently displayed page are selected. Rows on pages that are not the currently displayed will **not** be selected. | |
| For example, consider a paginated DataTable that displays 25 rows per page, with a total of 400 rows in the table. All rows on the current page are selected by the user. Deleting the selected rows should remove only the displayed rows, as to avoid unintentionally applying a destructive act to the other 375 rows. |
| If the data table is paginated, the "Select all rows" checkbox is activated, all rows on the currently displayed page are selected. Rows on pages that are not the currently displayed will **not** be selected. | ||
| For example, consider a paginated data table that displays 25 rows per page, with a total of 400 rows in the table. All rows on the current page are selected by the user. Deleting the selected rows should remove only the displayed rows, as to avoid unintentionally applying a destructive act to the other 375 rows. | ||
|
|
||
| A selected row's state **does not** persist if another page is requested. For example, consider a data table component that displays 15 rows per page. On page two, a user selects row 21, and then requests page one. Row 21's selected state is changed to deselected after page one's content is displayed. |
Contributor
There was a problem hiding this comment.
Suggested change
| A selected row's state **does not** persist if another page is requested. For example, consider a data table component that displays 15 rows per page. On page two, a user selects row 21, and then requests page one. Row 21's selected state is changed to deselected after page one's content is displayed. | |
| A selected row's state **does not** persist if another page is requested. For example, consider a DataTable component that displays 15 rows per page. On page two, a user selects row 21, and then requests page one. Row 21's selected state is changed to deselected after page one's content is displayed. |
Contributor
Author
|
I completely forgot I opened this PR. Will come back to it and get it merged this week 😅 |
Contributor
Author
|
I'm waiting for the implementation to be done before getting this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content is ready for review, but the screen recordings for the example videos are not ready yet. Screen recordings will be created once the DataTable component supports selection.