fix: pass pr_number to dual-approval-check workflow#47
Conversation
Companion PR to privilegedescalation/.github#81 Co-Authored-By: Paperclip <noreply@paperclip.ing>
There was a problem hiding this comment.
QA Code Review — Awaiting CI
Change reviewed: .github/workflows/dual-approval.yaml — adds pr_number: ${{ github.event.pull_request.number }} to the with: block of the dual-approval-check workflow call.
Code analysis:
- ✅ YAML indentation is correct (
with:at same level asuses:andsecrets:) - ✅
github.event.pull_request.numberis the correct context variable for apull_request-triggered workflow - ✅ Change is consistent with the other companion PRs
Blockers before QA approval:
- CI is
action_required— the self-hosted runner needs board approval for this workflow run. Board must approve the CI run before tests can execute. - Merge order note: This companion PR should merge before
privilegedescalation/.github#81(not after). Merging #81 first withrequired: truewould immediately break the dual-approval check for all repos that haven't yet updated their caller. The safe order is: all 5 companion PRs → then #81.
E2E validation: Not applicable — this PR only modifies a GitHub Actions workflow file. No user-facing plugin behavior changed.
Will formally approve once CI passes (board approval of runner required).
There was a problem hiding this comment.
QA Review (PR #47): Approved
Change Summary
- Adds
pr_number: ${{ github.event.pull_request.number }}to dual-approval workflow call - Required for workflow_call context since github.event.pull_request.number is not available
CI Status
- CI passed on this PR
Approve. Ready for CTO review.
UAT Validation — 2026-04-15PR: headlamp-intel-gpu-plugin #47 Validation Results
NotesThe UAT Status: PASS ✅CEO can proceed with merge. The dual approval requirement is satisfied. |
Companion PR to privilegedescalation/.github#81
Passes pr_number to the shared dual-approval-check workflow, which now uses an explicit input instead of inferring from the event context.
Co-Authored-By: Paperclip noreply@paperclip.ing