Fix inconsistent main icon detection, closes #496#498
Merged
probonopd merged 3 commits intoprobonopd:masterfrom Dec 15, 2022
kefir500:fix/icon-detection
Merged
Fix inconsistent main icon detection, closes #496#498probonopd merged 3 commits intoprobonopd:masterfrom kefir500:fix/icon-detection
probonopd merged 3 commits intoprobonopd:masterfrom
kefir500:fix/icon-detection
Conversation
Owner
Merged
Contributor
Author
|
Hi @probonopd, |
Owner
|
Thank you very much @kefir500. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit from this PR fixes the inconsistency in the main icon detection algorithm described in #496.
I accidentally messed up while rebasing, but seems that everything is ok now. Here is a proper pull request containing a commit based on the latest changes to
master(to keep the Git history clean).