update minimum version of cmake now that version 3.5 of cmake has been deprecated

[NissimBendanan]

No description provided.

[probonopd]

Why would we ever want to do that? I think it is good that our software still builds using older build systems.

[NissimBendanan]

Cmake in its last version 4.0.0. has deprecated those old versions and Cmake is failing to configure our projects.

…

________________________________ From: probonopd ***@***.***> Sent: Monday, March 31, 2025 22:23 To: probonopd/linuxdeployqt ***@***.***> Cc: Ben Danan, Nissam ***@***.***>; Author ***@***.***> Subject: Re: [probonopd/linuxdeployqt] update minimum version of cmake now that version 3.5 of cmake has been deprecated (PR #632) Why would we ever want to do that? I think it is good that our software still builds using older build systems. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/probonopd/linuxdeployqt/pull/632*issuecomment-2767186864__;Iw!!GjvTz_vk!QkGTe5RCk3Xxn2AbSDap3a4YqRpucXjGxYNJDerft9xjQU3EPTLyiDxCoPmjwld9H1adlhtDhDts9vY40a-dgFM$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A43LCQ7QSIJRD6LKOQCWVE32XGIZNAVCNFSM6AAAAAB2EYR57WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRXGE4DMOBWGQ__;!!GjvTz_vk!QkGTe5RCk3Xxn2AbSDap3a4YqRpucXjGxYNJDerft9xjQU3EPTLyiDxCoPmjwld9H1adlhtDhDts9vY4jVfK0YY$>. You are receiving this because you authored the thread.Message ID: ***@***.***> [probonopd]probonopd left a comment (probonopd/linuxdeployqt#632)<https://urldefense.com/v3/__https://github.com/probonopd/linuxdeployqt/pull/632*issuecomment-2767186864__;Iw!!GjvTz_vk!QkGTe5RCk3Xxn2AbSDap3a4YqRpucXjGxYNJDerft9xjQU3EPTLyiDxCoPmjwld9H1adlhtDhDts9vY40a-dgFM$> Why would we ever want to do that? I think it is good that our software still builds using older build systems. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/probonopd/linuxdeployqt/pull/632*issuecomment-2767186864__;Iw!!GjvTz_vk!QkGTe5RCk3Xxn2AbSDap3a4YqRpucXjGxYNJDerft9xjQU3EPTLyiDxCoPmjwld9H1adlhtDhDts9vY40a-dgFM$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A43LCQ7QSIJRD6LKOQCWVE32XGIZNAVCNFSM6AAAAAB2EYR57WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRXGE4DMOBWGQ__;!!GjvTz_vk!QkGTe5RCk3Xxn2AbSDap3a4YqRpucXjGxYNJDerft9xjQU3EPTLyiDxCoPmjwld9H1adlhtDhDts9vY4jVfK0YY$>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[NissimBendanan]

this is the cmake config error with cmake_minimum_required(VERSION 3.2):

[cmake] CMake Error at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required):
[cmake] Compatibility with CMake < 3.5 has been removed from CMake.
[cmake]
[cmake] Update the VERSION argument value. Or, use the ... syntax

even after my change to update to the minimum version supported by cmake (currently 3.5), we don't get an error but a warning:

[cmake] CMake Deprecation Warning at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required):
[cmake] Compatibility with CMake < 3.10 will be removed from a future version of
[cmake] CMake.
[cmake]
[cmake] Update the VERSION argument value. Or, use the ... syntax
[cmake] to tell CMake that the project requires at least but has been updated
[cmake] to work with policies introduced by or earlier.

So, the latest version of cmake 4.0.0. no longer supports versions earlier than 3.5

[alzix]

GitHub actions ubuntu runner was recently updated to include CMake version 4.0.0 - see https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20250330.1
This PR fixes the compilation error caused by a compatibility issue with the new CMake version.

Why would we ever want to do that?

You must decide whether to support legacy CMake versions or newer versions. The majority of developers will have a newer version of CMake installed.
Notice the change set minimum required version to 3.5 released in 2018. But the warning says it will be removed soon as well.
| suggest setting it to 3.10 right now

[probonopd]

Closing in favor of #633