Conversation
|
Hi @Affection5172, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
I have also tried to modify the dateFormat.ts file before to make it conform to the date format in the Chinese environment, but I am not good at doing this kind of thing. I'm sorry, this is all I can do. |
Metalhearf
left a comment
There was a problem hiding this comment.
Hi thanks a lot for the update and this first PR, really appreciated!
I don't read Chinese myself, so I can't judge the wording directly, but the diff looks consistent and the changes seem like sensible refinements (punctuation, terminology, tone). I'll trust your judgment on the language side.
-
One thing I did catch that I'd like fixed before we merge: two interpolation placeholders have a missing opening brace, which will break variable substitution at runtime:
- destroyHatConfirm: "{title}}" should be "{{title}}" (line 334)
- pollVoteReceived: "{title}}" should be "{{title}}" (line 375)
-
Our CLA bot reports that we don't have a signed Contributor License Agreement from you yet (hence the
cla-missinglabel). We can't merge contributions without it but it's a quick process: could you please sign it via the link the bot posted on the PR? Once that's done and the two placeholders are fixed, we'll be happy to merge.
Thanks!
|
Okay, I understand. Thank you very much. |
Hello, it’s been over two months since I last provided a translation, and Fluux Messenger has undergone many changes, so I’d like to update the translation.