Skip to content

Simplified Chinese Update#363

Open
Affection5172 wants to merge 2 commits intoprocessone:mainfrom
Affection5172:main
Open

Simplified Chinese Update#363
Affection5172 wants to merge 2 commits intoprocessone:mainfrom
Affection5172:main

Conversation

@Affection5172
Copy link
Copy Markdown

Hello, it’s been over two months since I last provided a translation, and Fluux Messenger has undergone many changes, so I’d like to update the translation.

@p1bot
Copy link
Copy Markdown
Collaborator

p1bot commented Apr 23, 2026

Hi @Affection5172, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added the cla-missing Contributor needs to sign Agreement (CLA) label Apr 23, 2026
@Affection5172
Copy link
Copy Markdown
Author

I have also tried to modify the dateFormat.ts file before to make it conform to the date format in the Chinese environment, but I am not good at doing this kind of thing. I'm sorry, this is all I can do.

Comment thread apps/fluux/src/i18n/locales/zh-CN.json Outdated
Comment thread apps/fluux/src/i18n/locales/zh-CN.json Outdated
Copy link
Copy Markdown
Member

@Metalhearf Metalhearf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks a lot for the update and this first PR, really appreciated!

I don't read Chinese myself, so I can't judge the wording directly, but the diff looks consistent and the changes seem like sensible refinements (punctuation, terminology, tone). I'll trust your judgment on the language side.

  1. One thing I did catch that I'd like fixed before we merge: two interpolation placeholders have a missing opening brace, which will break variable substitution at runtime:

    • destroyHatConfirm: "{title}}" should be "{{title}}" (line 334)
    • pollVoteReceived: "{title}}" should be "{{title}}" (line 375)
  2. Our CLA bot reports that we don't have a signed Contributor License Agreement from you yet (hence the cla-missing label). We can't merge contributions without it but it's a quick process: could you please sign it via the link the bot posted on the PR? Once that's done and the two placeholders are fixed, we'll be happy to merge.

Thanks!

@Metalhearf Metalhearf added the i18n Internationalization and translation updates label Apr 23, 2026
@Metalhearf Metalhearf self-assigned this Apr 24, 2026
Copy link
Copy Markdown
Member

@Metalhearf Metalhearf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perfect, looks good to me now. :)

For the CLA, there's a small manual action we need to do on our side, you should receive it in your inbox next Wednesday.

@Affection5172
Copy link
Copy Markdown
Author

Okay, I understand. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-missing Contributor needs to sign Agreement (CLA) i18n Internationalization and translation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants