Skip to content

refactor(docker): remove RVM/nvm wrappers from Procfile generation#12

Merged
trogulja merged 2 commits intomainfrom
feat/docker-mise-procfile
Apr 2, 2026
Merged

refactor(docker): remove RVM/nvm wrappers from Procfile generation#12
trogulja merged 2 commits intomainfrom
feat/docker-mise-procfile

Conversation

@trogulja
Copy link
Copy Markdown
Collaborator

@trogulja trogulja commented Apr 1, 2026

Summary

  • Remove DEFAULT_RUBY / DEFAULT_NODE constants and read_node_version() helper
  • Simplify procfile_entry() — always emit name: cd /workspace/repo && cmd
  • No more bash -lc 'rvm use X && ...' wrappers in generated Procfiles

Why

Companion to productiveio/work#127 which replaces RVM+nvm with mise in the Docker dev container. Mise shims resolve runtime versions per-directory from .ruby-version / .node-version files — no explicit version switching needed in Procfile entries.

Changes

  • docker.rs: -58 lines, +8 lines (net -50)

Test plan

  • cargo check -p tb-devctl passes
  • DevPortal boots with simplified Procfile entry (cd /workspace/devportal && bundle exec rails server)

🤖 Generated with Claude Code

trogulja and others added 2 commits April 1, 2026 22:49
mise shims resolve Ruby/Node versions per-directory from .ruby-version
and .node-version files — no explicit version switching needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@trogulja trogulja marked this pull request as ready for review April 1, 2026 21:38
@trogulja trogulja requested a review from ilucin April 1, 2026 21:40
@trogulja trogulja merged commit 03c701d into main Apr 2, 2026
1 check passed
@trogulja trogulja deleted the feat/docker-mise-procfile branch April 2, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants