fix(tb-prod): holidays schema — replace date filter with after/before#14
Merged
FilipBuhinicek merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
…lidays The Productive API does not support `filter[date]` on the holidays endpoint despite the schema listing it. The actual API uses custom `after` and `before` filters (same pattern as allocations/activities). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trogulja
approved these changes
Apr 7, 2026
trogulja
added a commit
that referenced
this pull request
Apr 7, 2026
Regenerated schema.json from ai-agent's generate-schema script. New resources: approval_policy_assignments, calendar_events, email_threads, expense_line_items, integrations, resource_requests, scenario_bookings, slack_users New enums: approval_policy_target_type, booking_approval_status, integration_type, resource_request_status Also includes: param field additions across most resources, improved descriptions, and the holidays after/before filter fix from #14. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter: "date"from holidays schema — the Productive API rejectsfilter[date]on this endpointafterandbeforefilter fields (same pattern as allocations/activities) which the API actually supportstb-prod query holidays --filter '{"holiday_calendar_id": "112", "after": "2026-04-07", "before": "2026-04-21"}'Context
Discovered while using the release-tracker skill — holiday queries were failing silently and falling back to pagination + client-side filtering.
Direct curl confirmed:
filter[date]→ 400 error,filter[after]/filter[before]→ works.Test plan
tb-prod describe holidays --include schemashowsafterandbeforefilters instead ofdatetb-prod query holidays --filter '{"holiday_calendar_id": "112", "after": "2026-04-07", "before": "2026-04-21"}'returns correct resultscargo test -p tb-prod --lib filterpasses🤖 Generated with Claude Code