fix: cap oversized header/footer instead of throwing#24
Closed
fix: cap oversized header/footer instead of throwing#24
Conversation
When header + footer heights exceed the available page space (leaving less than bodyHeightMinimumFactor for the body), proportionally reduce all section setting heights to fit. Previously this threw an error crashing the entire PDF generation. Real-world case: A4 page (842px) with header 274px + footer 701px produced negative body height (-131px) and threw "Header/footer too big". Now sections are scaled down proportionally, clipping excess content while still producing a valid PDF. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Header/footer too bigerrorContext
OpenURI::HTTPError: 500 Internal Server Errorinproposals/proposals#send_mailError: Header/footer too big. Page height: 842px, header: 274px, footer: 701px, body: -131pxHow it works
capOversizedSections()increatePageLayoutSettingsdetects whenheaderHeight + footerHeight > pageHeight * (1 - bodyHeightMinimumFactor)and applies a proportional scale factor to all header/footer section settings. The capped settings are cloned (original settings are not mutated) and passed through tocalculatePageLayoutand downstream rendering.The internal
calculatePageLayoutvalidation is preserved as-is — it still throws if called directly with invalid values, maintaining the library's invariants.Test plan
🤖 Generated with Claude Code