More mam fixes#2185
Merged
Merged
Conversation
The MAM result-set forward pagination logic in the RSM ID handler incorrectly extracted the 'first' element from the result set and used it as 'before', which caused paging to immediately terminate after the first page of results. This changes the logic to use 'last' and 'after' so that forward paging can proceed through all available pages on the server. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
The win_page_down function only triggered scrollback history queries from the database when the window type was WIN_CHAT. This extends it to also support WIN_MUC windows using mucwin_db_history. So download scrolling works as well. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Not convinced it's a good idea. It will just put more load on us. If people cannot fix the bug themselves they should at least take the time to create an account to report them. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Fix our resource displaying instead of our outgoing stamp when loading locally logged MUC history. This occurs because our client logs our outgoing MUC messages with our real bare JID and resource. For other participants (regardless of MUC anonymity), messages are always logged with the room bare JID as the `from_jid` and their room nickname as the resource. Fixes: #2184 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Member
Author
|
Tested by maniac and vamp898 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maniacmentioned `when I scroll like, 2 months backwards in time in the chat history, I can only scroll forwards in time a month.So we found a bug in rsm pagination.
Also add a note how to report bugs if you don't have an GH account.
And last but not least a fix for the wrong display name.