fix: correct model IDs + contract CEI violation documentation#7
Open
ether-btc wants to merge 4 commits into
Open
fix: correct model IDs + contract CEI violation documentation#7ether-btc wants to merge 4 commits into
ether-btc wants to merge 4 commits into
Conversation
On-chain model IDs had drifted from the hardcoded lookup table: - glm-5: fixed (was 0xd486af39, now 0x2034b95f) - kimi-k2-thinking: fixed (was 0xc40b0a1e, now 0xc40b6871) - kimi-k2-thinking:web, kimi-k2.6:web: added (were missing) - glm-5:web, glm-5.1, glm-5.1:web: added (were missing) - glm-4.7-flash:web, glm-4.7:web, glm-4.7-thinking, glm-4.7-thinking:web: added - hermes-3-llama-3.1-405b:web, llama-3.3-70b:web, gpt-oss-120b:web, venice-uncensored:web: added - gpt-oss-120b, hermes-3-llama-3.1-405b, qwen3-235b, venice-uncensored: IDs corrected - qwen3-coder-480b → renamed to qwen3-coder-480b-a35b-instruct - Stale placeholder entries (whisper-v3-large-turbo, tts-kokoro, text-embedding-bge-m3) removed Also fixes ShellCheck SC2002 (useless cat) in get_auth(). Detected by cross-referencing router /blockchain/models endpoint against hardcoded IDs in the lookup table. See: wiki/audits/morpheus-everclaw-audit-2026-05-25.md
Co-authored-by: Hermes Agent <hermes@nousresearch.com>
…ed-mor security fixes - scripts/balance.sh, chat.sh: SC2002 useless cat - scripts/always-on.sh: SC2145 array/string mix ($@ -> $*) - three-shifts/SKILL.md: carryover guard, cycle math, duplicated steps, undefined idle - skills/three-shifts/SKILL.md: step numbering, carryoverFromField cleanup - scripts/recover-locked-mor.mjs: TX status check, gas estimation, parseInt range validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 critical correctness bugs found during automated skill audit (2026-05-25).
Bugs Fixed
What Changed
session.sh: Model ID lookup table now reflects current on-chain registry. Added missing :web variants, corrected renamed models, removed non-existent placeholder entries (whisper, tts-kokoro, text-embedding). Also fixed SC2002 (useless cat) in get_auth().
models-config.json: Fixed glm-5 and kimi-k2-thinking model IDs.
cron-packs/SKILL.md + package-lock.json: Updated cron-pack manifest.
Documentation Added
Known Issue (Not Fixable in This PR)
The Diamond contract has a CEI violation in function 0xa85a1782 — MOR tokens are transferred before session validation. This causes MOR to be permanently drained on failed session opens. Filed as issue #6.
See full audit report: wiki/audits/morpheus-everclaw-audit-2026-05-25.md