Skip to content

ProGrad ID: 8757 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trishasinha22 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ProGrad ID: 8757 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Super Wars</title>
<link rel="stylesheet" href="src/style.css">
<link rel="stylesheet" href="./src/style.css">
</head>

<body>
Expand All @@ -23,6 +23,6 @@
</div>
<footer class="footer">Made with <img src="/images/Vector.svg"> by ProGrad</footer>
</body>
<script src="src/app.js"></script>
<script src="./src/app.js"></script>

</html>
18 changes: 15 additions & 3 deletions src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,21 @@ const PLAYERS = [

// initialize players with image and strength
const initPlayers = (players) => {
let detailedPlayers = '';
let detailedPlayers = [];

// Instead of forloop use Map method
// Code here
players.map((p,i) => {
let agent={};
agent.name=p;
agent.strength = getRandomStrength();
agent.image = `images/super-${i + 1}.png`;
agent.type = i % 2 == 0 ? "hero" : "villain";
detailedPlayers.push(agent);
});

return detailedPlayers;
}
};

// getting random strength
const getRandomStrength = () => {
Expand All @@ -43,7 +51,11 @@ const buildPlayers = (players, type) => {
// Instead of using for loop
// Use chaining of Array methods - filter, map and join
// Type your code here

fragment=players.filter((p) => p.type == type).map((p,i) => {return `<div class="player">
<img src="${players[i].image}" alt="">
<div class="name">${players[i].name}</div>
<div class="strength">${players[i].strength}</div>
</div>`}).join("");
return fragment;
}

Expand Down