Skip to content

Harden Sparkle release validation#4

Merged
progresshans merged 5 commits into
developfrom
feature/harden-sparkle-release
May 7, 2026
Merged

Harden Sparkle release validation#4
progresshans merged 5 commits into
developfrom
feature/harden-sparkle-release

Conversation

@progresshans

Copy link
Copy Markdown
Owner

Summary

  • simplify generated release notes
  • validate the Sparkle public key before release packaging proceeds
  • fail release packaging when the generated appcast is missing an EdDSA signature
  • document the Sparkle key formatting requirement for maintainers

Why

A malformed update signing configuration can produce a build that cannot start Sparkle update checks. The release workflow should fail before publishing that kind of artifact.

Validation

  • swift test
  • bash -n script/package_release.sh
  • GitHub Actions workflow YAML parse check
  • git diff --check

@progresshans progresshans self-assigned this May 7, 2026
@progresshans progresshans marked this pull request as ready for review May 7, 2026 16:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cbf7edad9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread script/package_release.sh Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9395f5ca3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread script/package_release.sh Outdated
@progresshans progresshans merged commit 057e20f into develop May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant