Add nfc-onnetwork pairing mode#296
Draft
OlivierGre wants to merge 2 commits intoproject-chip:v2.15-developfrom
Draft
Add nfc-onnetwork pairing mode#296OlivierGre wants to merge 2 commits intoproject-chip:v2.15-developfrom
OlivierGre wants to merge 2 commits intoproject-chip:v2.15-developfrom
Conversation
Contributor
Summary of ChangesHello @OlivierGre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the test harness's capabilities by integrating new pairing modes, particularly NFC-onnetwork, and enhancing the flexibility of test execution through a new CLI endpoint. It streamlines project management with import/export functionalities and introduces dynamic test exclusion via DMP files. A major refactoring of Python test collection handling improves performance and maintainability, while new logging features enhance visibility into container operations and test execution progress. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces a new NFC-on-network pairing mode, which includes adding the new mode to the DutPairingModeEnum, updating test suite configurations to recognize this new mode, and implementing corresponding test cases and pairing functions. The changes appear to be functionally correct and well-tested, ensuring the new pairing mode is properly integrated into the existing framework.
rquidute
approved these changes
Feb 19, 2026
antonio-amjr
approved these changes
Feb 19, 2026
OlivierGre
commented
Feb 19, 2026
test_collections/matter/sdk_tests/support/tests/python_tests/test_utils.py
Show resolved
Hide resolved
OlivierGre
force-pushed
the
add_nfc_on_network
branch
from
6062cd7 to
4d938bf
Compare
rquidute
approved these changes
Feb 23, 2026
oxesoft
approved these changes
Feb 23, 2026
Contributor
antonio-amjr
left a comment
antonio-amjr
left a comment
There was a problem hiding this comment.
Hi Olivier,
Can you verify the following concern below?
Thanks.
Comment on lines
+128
to
+135
| assert [ | ||
| "--trace-to json:log", | ||
| "--commissioning-method nfc-on-network", | ||
| "--discriminator 123", | ||
| "--passcode 1234", | ||
| "--paa-trust-store-path /paa-root-certs", | ||
| "--storage_path /root/admin_storage.json", | ||
| ] == arguments |
Contributor
There was a problem hiding this comment.
Is this Unit Test passing?
I made a recent change at the utils.py file that verify if a NFC pairing mode is being used, ignoring the discriminator and the passcode in case positive (please refer to the "NFC_PAIRING_MODES" variable).
I thought that the assert should not have both --discriminator and --passcode in the NFC case.
Can you take a look @OlivierGre?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nfc-onnetwork pairing mode. It will allow to test Ethernet devices supporting NFC commissioning