Skip to content

Feature/909 Improve CLI unit tests code coverage for camera files #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rquidute merged 8 commits into from
Mar 10, 2026
+2,354 −1,187
Merged

Feature/909 Improve CLI unit tests code coverage for camera files #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0810e4
Fixed Screenshot camera verification
rquidute Mar 9, 2026
bf5af96
Fixed copyright year
rquidute Mar 9, 2026
046a35a
Code review Gemini-code-assist
rquidute Mar 9, 2026
4707c82
Code review Gemini-code-assist
rquidute Mar 9, 2026
23a860b
Improve CLI test coverage across camera files and minor static analys…
rquidute Mar 10, 2026
77db935
Undo cov-fail-under change
rquidute Mar 10, 2026
ac2e0ff
Merge branch 'v2.15-cli-develop' into feature/909_unit_tests_camera
rquidute Mar 10, 2026
6cd5e56
black formating
rquidute Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ omit = [
"*/__pycache__/*",
"*/api_lib_autogen/*",
"*/conftest.py",
"*/main.py",
]

[tool.coverage.report]
Expand Down
2 changes: 1 addition & 1 deletion tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
"""Test package for th_cli."""
"""Test package for th_cli."""
120 changes: 48 additions & 72 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
import pytest
from click.testing import CliRunner
from faker import Faker

from httpx import Headers

from th_cli.api_lib_autogen import models as api_models
from th_cli.api_lib_autogen.api_client import ApiClient, AsyncApis, SyncApis
from th_cli.api_lib_autogen.exceptions import UnexpectedResponse
from th_cli.colorize import set_colors_enabled

# Initialize faker instance for generating test data
fake = Faker()
Expand Down Expand Up @@ -91,17 +91,10 @@ def mock_json_config_file(temp_dir: Path) -> Path:
"setup_code": "20212223",
"discriminator": "3840",
"chip_use_paa_certs": False,
"trace_log": False
},
"network": {
"wifi": {
"ssid": "TestNetwork",
"password": "TestPassword123"
}
"trace_log": False,
},
"test_parameters": {
"custom_param": "test_value"
}
"network": {"wifi": {"ssid": "TestNetwork", "password": "TestPassword123"}},
"test_parameters": {"custom_param": "test_value"},
}
config_file = temp_dir / "test_config.json"
config_file.write_text(json.dumps(config_data, indent=2))
Expand Down Expand Up @@ -148,20 +141,15 @@ def sample_default_config_dict() -> dict:
"""Create a sample default configuration dictionary."""
return {
"network": {
"wifi": {
"ssid": "default_wifi",
"password": "default_password"
},
"thread": {
"operational_dataset_hex": "default_hex"
}
"wifi": {"ssid": "default_wifi", "password": "default_password"},
"thread": {"operational_dataset_hex": "default_hex"},
},
"dut_config": {
"pairing_mode": "ble-wifi",
"setup_code": "20202021",
"discriminator": "3840",
"trace_log": False
}
"trace_log": False,
},
}


Expand Down Expand Up @@ -211,17 +199,19 @@ def sample_project() -> api_models.Project:
config={
"network": {
"wifi": {"ssid": "TestWiFi", "password": "testpassword"},
"thread": {"operational_dataset_hex": "0e080000000000010000000300001235060004001fffe0020811111111222222220708fd"}
"thread": {
"operational_dataset_hex": "0e080000000000010000000300001235060004001fffe0020811111111222222220708fd" # noqa
},
},
"dut_config": {
"pairing_mode": "ble-wifi",
"setup_code": "20202021",
"discriminator": "3840",
"trace_log": False
}
"trace_log": False,
},
},
created_at=fake.date_time(),
updated_at=fake.date_time()
updated_at=fake.date_time(),
)


Expand All @@ -235,17 +225,17 @@ def sample_projects() -> list[api_models.Project]:
config={
"network": {
"wifi": {"ssid": "test", "password": "test"},
"thread": {"operational_dataset_hex": "test"}
"thread": {"operational_dataset_hex": "test"},
},
"dut_config": {
"pairing_mode": "ble-wifi",
"setup_code": "20202021",
"discriminator": "3840",
"trace_log": False
}
"trace_log": False,
},
},
created_at=fake.date_time(),
updated_at=fake.date_time()
updated_at=fake.date_time(),
)
for i in range(1, 4)
]
Expand All @@ -265,36 +255,36 @@ def sample_test_collections() -> api_models.TestCollections:
public_id="FirstChipToolSuite",
version="1.0",
title="First Chip Tool Suite",
description="Test suite for chip tool testing"
description="Test suite for chip tool testing",
),
test_cases={
"TC-ACE-1.1": api_models.TestCase(
metadata=api_models.TestMetadata(
public_id="TC-ACE-1.1",
version="1.0",
title="Test Case ACE 1.1",
description="Access Control Entry test"
description="Access Control Entry test",
)
),
"TC-ACE-1.2": api_models.TestCase(
metadata=api_models.TestMetadata(
public_id="TC-ACE-1.2",
version="1.0",
title="Test Case ACE 1.2",
description="Access Control Entry test 2"
description="Access Control Entry test 2",
)
),
"TC-CC-1.1": api_models.TestCase(
metadata=api_models.TestMetadata(
public_id="TC-CC-1.1",
version="1.0",
title="Test Case CC 1.1",
description="Color Control test"
description="Color Control test",
)
)
}
),
},
)
}
},
),
"SDK Python Tests": api_models.TestCollection(
name="SDK Python Tests",
Expand All @@ -305,20 +295,20 @@ def sample_test_collections() -> api_models.TestCollections:
public_id="Python Testing Suite",
version="1.0",
title="Python Testing Suite",
description="Python test suite"
description="Python test suite",
),
test_cases={
"TC_ACE_1_3": api_models.TestCase(
metadata=api_models.TestMetadata(
public_id="TC_ACE_1_3",
version="1.0",
title="Test Case ACE 1.3",
description="Access Control Entry test 3"
description="Access Control Entry test 3",
)
)
}
},
)
}
},
),
"Custom SDK Python Tests": api_models.TestCollection(
name="Custom SDK Python Tests",
Expand All @@ -329,21 +319,21 @@ def sample_test_collections() -> api_models.TestCollections:
public_id="Python Testing Suite-custom",
version="1.0",
title="Python Testing Suite-custom",
description="Python test suite custom"
description="Python test suite custom",
),
test_cases={
"TC_ACE_1_3-custom": api_models.TestCase(
metadata=api_models.TestMetadata(
public_id="TC_ACE_1_3-custom",
version="1.0",
title="Test Case ACE 1.3 Custom",
description="Access Control Entry test 3 custom"
description="Access Control Entry test 3 custom",
)
)
}
},
)
}
)
},
),
}
)

Expand Down Expand Up @@ -380,9 +370,9 @@ def sample_test_run_execution() -> api_models.TestRunExecutionWithChildren:
title="Test Case ACE 1.1",
description="Access Control Entry test",
version="1.0",
source_hash="abc123"
source_hash="abc123",
),
test_step_executions=[]
test_step_executions=[],
)
],
test_suite_metadata=api_models.TestSuiteMetadata(
Expand All @@ -391,30 +381,23 @@ def sample_test_run_execution() -> api_models.TestRunExecutionWithChildren:
title="First Chip Tool Suite",
description="Test suite for chip tool testing",
version="1.0",
source_hash="def456"
)
source_hash="def456",
),
)
]
],
)


@pytest.fixture
def sample_test_runner_status() -> api_models.TestRunnerStatus:
"""Create a sample test runner status for testing."""
return api_models.TestRunnerStatus(
state=api_models.TestRunnerState.idle,
test_run_execution_id=None
)
return api_models.TestRunnerStatus(state=api_models.TestRunnerState.idle, test_run_execution_id=None)


@pytest.fixture
def mock_unexpected_response() -> UnexpectedResponse:
"""Create a mock UnexpectedResponse exception."""
return UnexpectedResponse(
status_code=404,
content=b"Not Found",
headers=Headers()
)
return UnexpectedResponse(status_code=404, content=b"Not Found", headers=Headers())


@pytest.fixture
Expand All @@ -424,7 +407,7 @@ def mock_versions_info() -> dict[str, Any]:
"backend_version": "1.0.0",
"backend_sha": "abc123def",
"test_harness_version": "2.0.0",
"test_harness_sha": "def456ghi"
"test_harness_sha": "def456ghi",
}


Expand All @@ -434,8 +417,6 @@ def disable_colors():
# Set environment variable to disable colors
os.environ["TH_CLI_NO_COLOR"] = "1"

# Import and set colors disabled programmatically as well
from th_cli.colorize import set_colors_enabled
set_colors_enabled(False)

yield
Expand All @@ -460,7 +441,7 @@ def get(self, key: str, default: Any = None) -> Any:

def dict(self) -> dict[str, Any]:
"""Convert response to dictionary."""
if hasattr(self.data, 'dict'):
if hasattr(self.data, "dict"):
return self.data.dict()
return self.data if isinstance(self.data, dict) else {}

Expand All @@ -477,21 +458,16 @@ def generate_test_project_data(**overrides) -> dict[str, Any]:
"name": fake.company(),
"config": {
"network": {
"wifi": {
"ssid": fake.name(),
"password": fake.password()
},
"thread": {
"operational_dataset_hex": "test_hex_value"
}
"wifi": {"ssid": fake.name(), "password": fake.password()},
"thread": {"operational_dataset_hex": "test_hex_value"},
},
"dut_config": {
"pairing_mode": "ble-wifi",
"setup_code": "20202021",
"discriminator": str(fake.random_int(min=0, max=4095)),
"trace_log": False
}
}
"trace_log": False,
},
},
}
data.update(overrides)
return data
Expand Down
Loading