feat!: drop support for '->' artwork#457
Draft
rchincha wants to merge 1 commit intoproject-stacker:mainfrom
Draft
feat!: drop support for '->' artwork#457rchincha wants to merge 1 commit intoproject-stacker:mainfrom
rchincha wants to merge 1 commit intoproject-stacker:mainfrom
Conversation
Contributor
|
I support leaving the ascii art behind, but if you can add a deprecation warning that explains how to replace it, that'd be really helpful. people currently using stacker will hit this in some number of months, when someone else updates their tool version, and they will need help understanding how to fix it. |
BREAKING CHANGE: '->' artwork syntax is dropped so older "bind:" directives will break, so users need to migrate/fix. stacker syntax uses a strange mix of yaml and artwork such as '->', for example in "bind:" directive. This PR makes it normal declarative yaml. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
changed the title
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: '->' artwork syntax is dropped so older "bind:" directives will break, so users need to migrate/fix.
stacker syntax uses a strange mix of yaml and artwork such as '->', for example in "bind:" directive. This PR makes it normal declarative yaml.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.