Open
Conversation
Added a new `get_nested_dict()` helper that parses dot-notation query Fixed the `CreateLaunchTemplate` (and `CreateLaunchTemplateVersion`) request parser to use the new `get_nested_dict()` instead of `get_scalar()` for `LaunchTemplateData` Fixed the XML serializer for `CreateSnapshot` responses Signed-off-by: Joeky <joeky5888@gmail.com>
Author
Update from the Meeting:
So
The snapshot response includes for item in param_data: # param_data is an int like 20 — can't iterate!
xml_parts.append(f'<item>{esc(str(item))}</item>')This crashes with <fullSnapshotSizeInBytes>20</fullSnapshotSizeInBytes>
<progress>0%</progress> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new
get_nested_dict()helper that parses dot-notation queryFixed the
CreateLaunchTemplate(andCreateLaunchTemplateVersion) request parser to use the newget_nested_dict()instead ofget_scalar()forLaunchTemplateDataFixed the XML serializer for
CreateSnapshotresponsesI've also added a github action to test the aws sdk in the project-vera/aws-testcases repo. This PR is going to fix the CI test.