Generate Rails 6 applications with Sprockets 4-style assets#2267
Merged
Generate Rails 6 applications with Sprockets 4-style assets#2267
Conversation
mjgiarlo
changed the title
mjgiarlo
changed the title
mjgiarlo
commented
Mar 28, 2020
mjgiarlo
commented
Mar 28, 2020
jcoyne
reviewed
Mar 30, 2020
mjgiarlo
force-pushed
the
rails-6-sprockets-6
branch
4 times, most recently
from
9af3da1 to
e30236c
Compare
Now when the test app is generated with Rails 6 (and Sprockets 4), the `blacklight:server` actually spins up instead of screaming about webpacker. Related to #2266
mjgiarlo
force-pushed
the
rails-6-sprockets-6
branch
from
e30236c to
251c07c
Compare
jcoyne
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blacklight is currently generating Rails 6 applications with Sprockets 3-style assets. With this change, the
blacklight:servertask spins up a working server (with Sprockets 4-style assets) instead of screaming about webpacker.Related to #2266, discovered in #2263.