[8.x] Backport facet modal bugfixes#3568
Merged
jcoyne merged 9 commits intorelease-8.xfrom Apr 16, 2025
Merged
Conversation
I don't think this is required or necessarily desirable. Remove it as it's easier to add in this pagination in a local app than it is to remove it when it's not desired
#3532 - BS5 btn classes are not meant for span tags (see https://getbootstrap.com/docs/5.3/components/buttons/#button-tags) - BS5 disabled buttons should not have an href, and should use aria-disabled="true" (see https://getbootstrap.com/docs/5.3/components/buttons/#disabled-state)
… and starting letter nav. Fixes #3515. - pass the search_facet_path into the input as a data-attribute; it has the facet's current search context - hide the facet's prev/next nav links when a user has entered text in the facet filter - add a .facet-suggestions class to distinguish suggested facet values from regular - check for .facet-suggestions in JS specs before checking other expectations, otherwise the debounce makes timing unpredictable
- original fix only added wrap for .pagination up to sm breakpoint; no harm in it applying at all widths
…ls. Fixes #3524 - render pagination & sort links near the top so scrolling isn't necessary to see/click them - style the top & bottom nav consistently - ensure these elements wrap appropriately in mobile/narrow viewports - improve display of facet browse UI when viewed on a facet page (as opposed to modal)
…appear if it's empty. Fixes #3552. - this area will be empty for facets configured with suggest: false - uses a simple :has CSS rule rather than complicate the template rendering
- Uses black w/0.5 opacity by default to match BS4 & BS5 modals (native dialog uses 0.1) - Adds --bl-modal-backdrop-bg CSS variable for downstream customization
Contributor
Author
|
Demo modal backdrop, with Demo facet page: |
… specs - In 8.x this feature is off by default, but on in 9.x
seanaery
force-pushed
the
bl8-backport-facet-modal-fixes
branch
from
5c6f454 to
b56ff25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports several related facet modal bugfixes that were recently made in
mainback to therelease-8.xbranch:The net effect of these changes in a Blacklight 8.x application:
morein a facet will open the modal for further exploration as expected. The modal will now have a slightly darker backdrop, matching the style for Bootstrap modals.prev/nextnav and sort options both at the top and bottom of the modal, and not above the modal header/title.index_range: 'A'..'Z'(or other range), the resultingAtoZnav will now appear in a gray box, and will wrap correctly at narrow viewports.suggest: true, the facet filter input (added in8.8.0) will also appear in a gray box, and will now work in concert with the sort options (as well as theindex_rangeA-Z nav if present)./catalog/facet/subject_ssim-- the facet UI displayed outside of a modal -- will now be presentable and useful; all the nav elements will now look correct on that page.