Allow advanced search to return results when no query is present#3810
Merged
sandbergja merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
sandbergja
deleted the
3809-advanced-search-returns-zero-results-with-blank-query
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making an advanced search with an empty query, the search builder switches to the lucene defType, which doesn't recognize the default
q.altconfiguration used to return all results with an empty query for a standard search. We can address this by making the guard clause that controls the switch to the lucene defType more robust :Do not switch to lucene if the clause params are blank OR all the query values within the clause params are blank
Screenshots
Below, is a search for records with the format facet "Book" on the advanced search form. Without a query value present, the search returns the expected records.