hook: align restart flow with default_hook.sh#952
Merged
Conversation
- remove "daemon-reload" from generic restartService() to avoid reloads on every network restart - keep "daemon-reload" only for NetworkManager DNS fix and undo fix via reloadAndRestartService() Signed-off-by: Aritra Basu <aritrbas@cisco.com>
sknat
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkManagerHookhad drifted fromdefault_hook.shby runningsystemctl daemon-reloadbefore every service restart.That made
restartNetwork()perform extra reloads forsystemd-networkd/NetworkManager/etc.This PR scopes
systemctl daemon-reloadto the DNS mutation paths (fixDNSandundoDNSFix) andtweakNetworkFile()matching the shell script.restartService()now only restarts the target service. A new functionreloadAndRestartService()has been added to handle "reload+restart" when needed. This should restore behavior parity withdefault_hook.sh.