chore(deps): update dependency golangci/golangci-lint to v2.12.1

.golangci.yml

@@ -5,8 +5,11 @@ run:
 linters:
   enable:
     - wsl_v5
+    - gomodguard_v2
   default: all
   disable:
+    - wsl
+    - gomodguard
     - revive
     - noinlineerr
     - depguard
@@ -39,6 +42,9 @@ linters:
     gocognit:
       min-complexity: 50
     goconst:
+      ignore-string-values:
+        - "status"
+        - "path"
       min-len: 2
       min-occurrences: 2
     inamedparam:

Makefile

@@ -364,7 +364,7 @@ nwa:
 	$(call go-install-tool,$(NWA),github.com/$(NWA_LOOKUP)@$(NWA_VERSION))
 
 GOLANGCI_LINT          := $(LOCALBIN)/golangci-lint
-GOLANGCI_LINT_VERSION  := v2.11.4
+GOLANGCI_LINT_VERSION  := v2.12.1
 GOLANGCI_LINT_LOOKUP   := golangci/golangci-lint
 golangci-lint: ## Download golangci-lint locally if necessary.
 	@test -s $(GOLANGCI_LINT) && $(GOLANGCI_LINT) -h | grep -q $(GOLANGCI_LINT_VERSION) || \

internal/authorization/middleware.go

@@ -10,14 +10,15 @@ import (
 
 	"github.com/projectcapsule/capsule-proxy/internal/modules/clusterscoped"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 func MutateAuthorization(proxyClusterScoped bool, proxyTenants []*tenant.ProxyTenant, obj *runtime.Object, gvk schema.GroupVersionKind) error {
 	switch gvk.Kind {
 	case "SelfSubjectAccessReview":
 		//nolint:forcetypeassert
 		accessReview := (*obj).(*authorizationv1.SelfSubjectAccessReview)
-		if accessReview.Spec.ResourceAttributes.Resource == "namespaces" && accessReview.Spec.ResourceAttributes.Verb == "list" {
+		if accessReview.Spec.ResourceAttributes.Resource == types.Namespaces && accessReview.Spec.ResourceAttributes.Verb == types.ListVerb {
 			accessReview.Status.Allowed = true
 		}
 
@@ -57,8 +58,8 @@ func MutateAuthorization(proxyClusterScoped bool, proxyTenants []*tenant.ProxyTe
 
 		resourceRules = append(resourceRules, authorizationv1.ResourceRule{
 			APIGroups: []string{""},
-			Resources: []string{"namespaces"},
-			Verbs:     []string{"list"},
+			Resources: []string{types.Namespaces},
+			Verbs:     []string{types.ListVerb},
 		})
 		src := authorizationv1.SelfSubjectRulesReview{
 			Status: authorizationv1.SubjectRulesReviewStatus{

internal/modules/errors/bad_request.go

@@ -8,6 +8,8 @@ import (
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 //nolint:errname
@@ -33,8 +35,8 @@ func (b badRequest) Error() string {
 func (b badRequest) Status() *metav1.Status {
 	return &metav1.Status{
 		TypeMeta: metav1.TypeMeta{
-			Kind:       "Status",
-			APIVersion: "v1",
+			Kind:       types.StatusKind,
+			APIVersion: types.V1,
 		},
 		Reason:  metav1.StatusReasonBadRequest,
 		Message: b.message,

internal/modules/errors/not_found.go

@@ -9,6 +9,8 @@ import (
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type notFoundError struct {
@@ -36,8 +38,8 @@ func (e notFoundError) Error() string {
 func (e notFoundError) Status() *metav1.Status {
 	return &metav1.Status{
 		TypeMeta: metav1.TypeMeta{
-			Kind:       "Status",
-			APIVersion: "v1",
+			Kind:       types.StatusKind,
+			APIVersion: types.V1,
 		},
 		Reason:  metav1.StatusReasonNotFound,
 		Message: e.message,

internal/modules/ingressclass/get.go

@@ -20,6 +20,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -35,7 +36,7 @@ func Get(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   networkingv1.GroupName,
 			Version: "*",
-			Kind:    "ingressclasses",
+			Kind:    types.Ingressclasses,
 		},
 	}
 }

internal/modules/metric/get.go

@@ -19,6 +19,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -32,9 +33,9 @@ func Get(client client.Reader) modules.Module {
 		client: client,
 		log:    ctrl.Log.WithName("metric_get"),
 		gk: schema.GroupVersionKind{
-			Group:   "metrics.k8s.io",
+			Group:   types.MetricsGroup,
 			Version: "*",
-			Kind:    "nodes",
+			Kind:    types.Nodes,
 		},
 	}
 }

internal/modules/namespace/get.go

@@ -23,6 +23,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/errors"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	ctypes "github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -44,7 +45,7 @@ func Get(roleBindingsReflector *controllers.RoleBindingReflector, client client.
 		gk: schema.GroupVersionKind{
 			Group:   corev1.GroupName,
 			Version: "*",
-			Kind:    "namespaces",
+			Kind:    ctypes.Namespaces,
 		},
 	}
 }

internal/modules/namespace/list.go

@@ -18,6 +18,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/errors"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -33,7 +34,7 @@ func List(roleBindingsReflector *controllers.RoleBindingReflector) modules.Modul
 		gk: schema.GroupVersionKind{
 			Group:   corev1.GroupName,
 			Version: "*",
-			Kind:    "namespaces",
+			Kind:    types.Namespaces,
 		},
 	}
 }

internal/modules/node/list.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -32,7 +33,7 @@ func List(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   corev1.GroupName,
 			Version: "*",
-			Kind:    "nodes",
+			Kind:    types.Nodes,
 		},
 	}
 }

internal/modules/persistentvolume/get.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -36,7 +37,7 @@ func Get(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   corev1.GroupName,
 			Version: "*",
-			Kind:    "persistentvolumes",
+			Kind:    types.PersistentVolumes,
 		},
 	}
 }

internal/modules/persistentvolume/list.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -36,7 +37,7 @@ func List(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   corev1.GroupName,
 			Version: "*",
-			Kind:    "persistentvolumes",
+			Kind:    types.PersistentVolumes,
 		},
 	}
 }

internal/modules/priorityclass/get.go

@@ -20,6 +20,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -35,7 +36,7 @@ func Get(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   schedulingv1.GroupName,
 			Version: "*",
-			Kind:    "priorityclasses",
+			Kind:    types.PriorityClasses,
 		},
 	}
 }

internal/modules/priorityclass/list.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -32,7 +33,7 @@ func List(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   schedulingv1.GroupName,
 			Version: "*",
-			Kind:    "priorityclasses",
+			Kind:    types.PriorityClasses,
 		},
 	}
 }

internal/modules/runtimeclass/get.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -32,7 +33,7 @@ func Get(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   nodev1.GroupName,
 			Version: "*",
-			Kind:    "runtimeclasses",
+			Kind:    types.RuntimeClasses,
 		},
 	}
 }

internal/modules/runtimeclass/list.go

@@ -17,6 +17,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -32,7 +33,7 @@ func List(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   nodev1.GroupName,
 			Version: "*",
-			Kind:    "runtimeclasses",
+			Kind:    types.RuntimeClasses,
 		},
 	}
 }

internal/modules/storageclass/get.go

@@ -20,6 +20,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/utils"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -35,7 +36,7 @@ func Get(client client.Reader) modules.Module {
 		gk: schema.GroupVersionKind{
 			Group:   storagev1.GroupName,
 			Version: "*",
-			Kind:    "storageclasses",
+			Kind:    types.StorageClasses,
 		},
 	}
 }

internal/modules/tenants/get.go

@@ -19,6 +19,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/errors"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type get struct {
@@ -36,9 +37,9 @@ func Get(client client.Reader) modules.Module {
 		client:       client,
 		log:          ctrl.Log.WithName("tenant_get"),
 		gk: schema.GroupVersionKind{
-			Group:   "capsule.clastix.io",
+			Group:   types.CapsuleGroup,
 			Version: "*",
-			Kind:    "tenants",
+			Kind:    types.Tenants,
 		},
 	}
 }

internal/modules/tenants/list.go

@@ -16,6 +16,7 @@ import (
 	"github.com/projectcapsule/capsule-proxy/internal/modules/errors"
 	"github.com/projectcapsule/capsule-proxy/internal/request"
 	"github.com/projectcapsule/capsule-proxy/internal/tenant"
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 type list struct {
@@ -27,9 +28,9 @@ func List() modules.Module {
 	return &list{
 		log: ctrl.Log.WithName("tenant_list"),
 		gk: schema.GroupVersionKind{
-			Group:   "capsule.clastix.io",
+			Group:   types.CapsuleGroup,
 			Version: "*",
-			Kind:    "tenants",
+			Kind:    types.Tenants,
 		},
 	}
 }

internal/request/http.go

@@ -16,6 +16,8 @@ import (
 	"k8s.io/apiserver/pkg/authentication/serviceaccount"
 	"k8s.io/apiserver/pkg/authentication/user"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/projectcapsule/capsule-proxy/internal/types"
 )
 
 var websocketBearerTokenRegexp = regexp.MustCompile(`base64url\.bearer\.authorization\.k8s\.io\.([^,]*)`) //nolint:gochecknoglobals
@@ -127,7 +129,7 @@ func (h http) GetUserAndGroups() (username string, groups []string, err error) {
 				ac := &authorizationv1.SubjectAccessReview{
 					Spec: authorizationv1.SubjectAccessReviewSpec{
 						ResourceAttributes: &authorizationv1.ResourceAttributes{
-							Verb:     "impersonate",
+							Verb:     types.ImprisonateVerb,
 							Resource: "groups",
 							Name:     impersonateGroup,
 						},

internal/types/constnats.go

@@ -0,0 +1,18 @@
+package types
+
+const (
+	V1                string = "v1"
+	StatusKind        string = "Status"
+	ListVerb          string = "List"
+	Namespaces        string = "namespaces"
+	ImprisonateVerb   string = "impersonate"
+	Ingressclasses    string = "ingressclasses"
+	MetricsGroup      string = "metrics.k8s.io"
+	CapsuleGroup      string = "capsule.clastix.io"
+	Nodes             string = "nodes"
+	PersistentVolumes string = "persistentvolumes"
+	PriorityClasses   string = "priorityclasses"
+	RuntimeClasses    string = "runtimeclasses"
+	StorageClasses    string = "storageclasses"
+	Tenants           string = "tenants"
+)