fix: display HTTPS interactions in interactsh-client output#1359
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe CLI's interaction output formatting now dynamically displays the protocol (HTTP or HTTPS) instead of using fixed labels. Headers and verbose output section titles are updated to reflect the actual protocol from the interaction, while request and response bodies remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Neo - PR Security ReviewCaution Neo couldn't finish analyzing this pull request during this run. Please run the review again. Comment |
Mzack9999
left a comment
There was a problem hiding this comment.
- merge conflict
- optimization requested
5e3ad9e to
da5d985
Compare
Commit aab1b78 added protocol differentiation (HTTP vs HTTPS) on the server side but the client display switch only matched "http", silently dropping all HTTPS interactions. Made-with: Cursor
Address PR review feedback by storing the uppercase protocol name in a local variable instead of calling strings.ToUpper three times. Made-with: Cursor
da5d985 to
575889b
Compare
|
done @Mzack9999 @knakul853 |
|
fyi @knakul853 you would need to merge - i don't have permissions. |
Summary
httpProtocol()to differentiate HTTP vs HTTPS on the server, settingprotocolto"https"for TLS connectionscmd/interactsh-client/main.goonly matchedcase "http":, silently dropping all HTTPS interactions"https"to the case match and dynamically render the protocol name (HTTP/HTTPS) in the outputTest plan
Received HTTPS interactionappears in client outputMade with Cursor
Summary by CodeRabbit