Skip to content

fix: display HTTPS interactions in interactsh-client output#1359

Merged
dogancanbakir merged 2 commits intoprojectdiscovery:devfrom
svennergr:fix/client-display-https-interactions
May 6, 2026
Merged

fix: display HTTPS interactions in interactsh-client output#1359
dogancanbakir merged 2 commits intoprojectdiscovery:devfrom
svennergr:fix/client-display-https-interactions

Conversation

@svennergr
Copy link
Copy Markdown

@svennergr svennergr commented Mar 30, 2026

Summary

  • Commit aab1b78 introduced httpProtocol() to differentiate HTTP vs HTTPS on the server, setting protocol to "https" for TLS connections
  • The client display switch in cmd/interactsh-client/main.go only matched case "http":, silently dropping all HTTPS interactions
  • Added "https" to the case match and dynamically render the protocol name (HTTP/HTTPS) in the output

Test plan

  • Start interactsh-server with TLS enabled
  • Start interactsh-client, curl the generated URL over HTTPS
  • Verify Received HTTPS interaction appears in client output
  • Verify HTTP interactions still display correctly

Made with Cursor

Summary by CodeRabbit

  • Style
    • Improved CLI interaction output formatting to display protocol-specific headers. Headers now show the actual protocol used (HTTP or HTTPS) instead of generic labels, providing clearer information in both standard and verbose output modes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49ba5acd-fed0-43f5-9e20-3168b09bbb94

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The CLI's interaction output formatting now dynamically displays the protocol (HTTP or HTTPS) instead of using fixed labels. Headers and verbose output section titles are updated to reflect the actual protocol from the interaction, while request and response bodies remain unchanged.

Changes

Cohort / File(s) Summary
Protocol Display Enhancement
cmd/interactsh-client/main.go
Updated interaction output formatting to display protocol-specific headers and section titles. Fixed labels like "HTTP interaction" and "HTTP Request/HTTP Response" now use the interaction's actual protocol (HTTP or HTTPS) uppercased, while preserving underlying request/response data.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop! Now the headers dance,
No more "HTTP" in every glance,
HTTPS shines where it should be—
Protocol truth, for all to see! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and accurately summarizes the main change: fixing the display of HTTPS interactions in the interactsh-client output.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@neo-by-projectdiscovery-dev
Copy link
Copy Markdown

neo-by-projectdiscovery-dev Bot commented Mar 30, 2026

Neo - PR Security Review

Caution

Neo couldn't finish analyzing this pull request during this run. Please run the review again.

Comment @pdneo help for available commands. · Open in Neo

Comment thread cmd/interactsh-client/main.go Outdated
@Mzack9999 Mzack9999 changed the base branch from main to dev April 29, 2026 16:20
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • merge conflict
  • optimization requested

@svennergr svennergr force-pushed the fix/client-display-https-interactions branch from 5e3ad9e to da5d985 Compare April 30, 2026 05:27
Commit aab1b78 added protocol differentiation (HTTP vs HTTPS) on the
server side but the client display switch only matched "http", silently
dropping all HTTPS interactions.

Made-with: Cursor
Address PR review feedback by storing the uppercase protocol name
in a local variable instead of calling strings.ToUpper three times.

Made-with: Cursor
@svennergr svennergr force-pushed the fix/client-display-https-interactions branch from da5d985 to 575889b Compare April 30, 2026 05:28
@svennergr
Copy link
Copy Markdown
Author

done @Mzack9999 @knakul853

@svennergr
Copy link
Copy Markdown
Author

fyi @knakul853 you would need to merge - i don't have permissions.

@dogancanbakir dogancanbakir merged commit 00e7063 into projectdiscovery:dev May 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants