Update .gitignore and enhance JSON output with root domain extraction#694
Open
0xh7ml wants to merge 5 commits intoprojectdiscovery:mainfrom
Open
Update .gitignore and enhance JSON output with root domain extraction#6940xh7ml wants to merge 5 commits intoprojectdiscovery:mainfrom
0xh7ml wants to merge 5 commits intoprojectdiscovery:mainfrom
Conversation
Neo - PR Security ReviewNo security issues found Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During active enumeration such as bruteforce or resolving subdomain. I've seen that while json output. It's only returning the hostname.
But it will be better if we print/write output like,
Subfinder output:
{"host": "honey.scanme.sh", "input": "scanme.sh"}Shuffledns output:
{"hostname": "honey.scanme.sh"}Now, I've updated the shuffledns json print/write output similar to subfinder thus we can combine these tool's output more efficiently in our recon workflow:
{"host": "honey.scanme.sh", "input": "scanme.sh"}