Fix self signed false positives

[ehsandeep]

A bug introduced in #845

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-self-signed-false-positives

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tarunKoyalwar]

lgtm !

[ehsandeep]

@coderabbitai create and link github issue for this PR

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

I'll create a GitHub issue for this PR. Let me first gather some details about the PR to create a meaningful issue.

---

🏁 Script executed:

#!/bin/bash
# Get current PR details
gh pr view --json title,body,url,number

# Get details about the referenced PR #845 that introduced the bug
gh pr view 845 --json title,body,url || echo "PR #845 details not available"

# Look at the commit messages and changes in current PR
git log --oneline -5

# Get a summary of files changed in this PR
gh pr diff --name-only

Length of output: 1032

---

Let me try to get the PR details directly and understand the changes made.

---

🏁 Script executed:

#!/bin/bash
# Try to get PR #860 details directly
gh pr view 860 --json title,body,url,number || echo "PR #860 details not directly available"

# Check recent commits to understand what was changed
git log --oneline --grep="self" --grep="signed" --grep="false" -i -10

# Look for files that might contain self-signed certificate logic
fd -e go | xargs grep -l -i "selfsigned\|self.*signed" | head -5

# Check git diff to see what files were changed recently
git diff --name-only HEAD~3..HEAD

Length of output: 649

---

Perfect! Now I have the details I need. Let me create a GitHub issue for this PR.

---

🏁 Script executed:

#!/bin/bash
# Create a GitHub issue for the PR
gh issue create \
  --title "Self-signed certificate false positives bug" \
  --body "## Description

This issue tracks a bug related to self-signed certificate detection that was introduced in PR #845.

## Background

PR #845 (\"Fix the IsSelfSigned Detection\") improved detection of self-signed certificates by extending the check for empty SANs. However, this change introduced false positives in self-signed certificate detection.

## Fix

PR #860 (\"Fix self signed false positives\") addresses these false positives.

## References

- Original PR that introduced the bug: https://github.com/projectdiscovery/tlsx/pull/845
- Fix PR: https://github.com/projectdiscovery/tlsx/pull/860

## Reporter

@ehsandeep" \
  --assignee ehsandeep

Length of output: 777

---

@ehsandeep I've successfully created and linked a GitHub issue for this PR:

Issue #862: Self-signed certificate false positives bug

The issue documents:

• The bug that was introduced in PR Fix the IsSelfSigned Detection #845 ("Fix the IsSelfSigned Detection")
• How PR Fix self signed false positives #860 ("Fix self signed false positives") addresses the false positives
• References to both the original PR that caused the issue and the current fix PR
• Assignment to you as requested

The issue is now linked and ready for tracking this bug fix.