Skip to content

fix(runner): accept raw IPv6 inputs without treating as host:port#924

Closed
Rhan2020 wants to merge 1 commit intoprojectdiscovery:devfrom
Rhan2020:fix/multiple-prefixes-tls-handshake-hostname
Closed

fix(runner): accept raw IPv6 inputs without treating as host:port#924
Rhan2020 wants to merge 1 commit intoprojectdiscovery:devfrom
Rhan2020:fix/multiple-prefixes-tls-handshake-hostname

Conversation

@Rhan2020
Copy link

@Rhan2020 Rhan2020 commented Feb 26, 2026

Fixes #859.

When passing an IPv6 literal like 2a03:2880:11ff:17::face:b00c (no brackets) as input, the runner treated it as host:port and failed parsing.

This change:

  • Parses the input URL (if any) and then uses a loose host/port split.
  • Accepts bracketed IPv6 with port ([...]:443) and classic host:port.
  • Treats multi-colon unbracketed values as IPv6 literals with no explicit port.

Added a small unit test covering domain, IPv4, IPv6, and bracketed IPv6+port.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@neo-by-projectdiscovery-dev
Copy link

neo-by-projectdiscovery-dev bot commented Feb 26, 2026

Neo - PR Security Review

No security issues found

Highlights

Comment @neo help for available commands. · Open in Neo

@Rhan2020 Rhan2020 closed this by deleting the head repository Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant