🔒 Fix: Migrate token storage to HttpOnly cookies#68
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request transitions the authentication mechanism from token-based authorization headers stored in session storage to HttpOnly cookies. It introduces the cookie-parser dependency, configures CORS to support credentials, and updates the cabpMiddleware to read the JWT token from cookies with a fallback to the Authorization header. On the client side, token checks and manual header injection are replaced with credentials: "include" on the transport layer. Relevant tests have been updated or added to verify the cookie-based authentication middleware. There are no review comments, and I have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🎯 What: The application was storing authentication tokens in
⚠️ Risk: Storing sensitive tokens in
sessionStorageinapp/public/app.jsand reading them on the frontend.sessionStorageexposes them to Cross-Site Scripting (XSS) attacks, as any malicious JavaScript injected into the application can access them.🛡️ Solution: The application was updated to use
HttpOnlycookies for token storage. We addedcookie-parserto the Express backend inapp/server.js, updatedcabpMiddlewareto read the token directly fromreq.cookies.token(while keeping Authorization header checking as a fallback), and configured CORScredentials: true. On the frontend, we removedsessionStoragelookups, instead enablingcredentials: "include"onStreamableHTTPClientTransportso thatHttpOnlycookies are seamlessly included with the request securely. All redundant token-checking frontend tests were pruned, and a backend cookie authorization test was introduced to ensure strict safety validations.PR created automatically by Jules for task 9967362965505343792 started by @projectedanx