Conversation
eemeli
left a comment
There was a problem hiding this comment.
The test errors seem rather significant here, as they're changing the behaviour of the locale matching. Given the different treatment of subtags like macos and ca-japanese in our locale.ts and the standard Intl.Locale, I'm not sure that these are easily reconcilable without some observable changes.
Effectively, this is pointing out that our current understanding of locale tags is nonstandard, and that's a bit of a problem.
I wonder if we could use Intl.Locale for matching on language, region & script, and do something else for the rest?
|
Yes as you can see I handle the private-usage part by just reading the last subtag (because its always the last one), what should I do? |
|
I also personally ended up using a ponyfill of the Intl.LocaleMatcher standard proposal in my code. |
I see that. Hmmm. Could you make use of the normalization done in the |
|
Closing in favour of #605. |
Requires fixing some test errors