Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need a rebase once #652 is merged. Only the latest six commits are really part of this PR.Closes Loop detection could be done in message/term reference instead of pattern (?) #277
As suggested in the issue, loop detection is moved to message & term resolution. It now tracks expressions rather than patterns.
Closes @fluent/bundle how to use FluentType.toString #426
While the type of
Scopeis indeed public, it's here made an optional argument of all FluentType.p.toString() implementations.Closes Accept boolean variables in
Localizedcomponent #543Boolean values are supported as argument values; internally, they are handled as strings, serialised as either
"true"or"false".Closes Automatic Eastern Arabic numerals in Arabic translations?H #583
Formatting with
aras the locale continues to default to Latin digits, but the numbering system can be customized for all messages via a locale extension (e.g.ar-u-nu-arab), or for a specific placeholder by wrapping the number in a FluentNumber and specifying itsnumberingSystemoption value. Tests are added to validate this.Closes Request Feature: Support prefix identifier for message #624
The parser is moved to a function outside the FluentResource class, which effectively makes it private within that module. It's also slightly optimised, e.g. removing repetitions of testing the same string with the same regexp.
Additionally, a selector with no variants is now treated as a syntax error, as it should be.