fix: clean up of resources from deleted clusters.#504
Merged
Conversation
Clean up ClusterProfile/ConfigMap/Secret and EventReport left behind by deleted clusters If a Cluster/SveltosCluster is deleted (or event-manager is down when it happens), the EventReport, ClusterProfile, ConfigMap, and Secret instances that were created because of it could be left behind indefinitely. The existing cleanup paths were triggered off Cluster delete watches or off EventTrigger reconciles. The cluster ones can be missed the transition entirely if event-manager wasn't running at the time. This PR fixes that. A new `pollStaleEventReports` background loop (5-minute tick, only on the default/non-sharded instance, independent of EventReportMode): lists every Cluster/SveltosCluster cluster-wide and every EventReport, and for any EventReport whose cluster no longer exists, removes every EventTrigger's instantiated ClusterProfile/ConfigMap/Secret for that cluster plus the stale EventReport itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up ClusterProfile/ConfigMap/Secret and EventReport left behind by deleted clusters
If a Cluster/SveltosCluster is deleted (or event-manager is down when it happens), the EventReport, ClusterProfile, ConfigMap, and Secret instances that were created because of it could be left behind indefinitely. The existing cleanup paths were triggered off Cluster delete watches or off EventTrigger reconciles. The cluster ones can be missed the transition entirely if event-manager wasn't running at the time.
This PR fixes that. A new
pollStaleEventReportsbackground loop (5-minute tick, only on the default/non-sharded instance, independent of EventReportMode): lists every Cluster/SveltosCluster cluster-wide and every EventReport, and for any EventReport whose cluster no longer exists, removes every EventTrigger's instantiated ClusterProfile/ConfigMap/Secret for that cluster plus the stale EventReport itself.