fix: invalidate workload identity cache when SveltosCluster spec changes#641
Merged
Merged
Conversation
getWorkloadIdentityRestConfig caches the built rest.Config per cluster in an in-memory wiCache, keyed only by namespace/name. Eviction is only wired up in each component's SveltosCluster delete handler nothing invalidates the cache on update. So editing spec.workloadIdentity had no effect until the cached cloud token neared its natural expiry The fix consist in hashing spec.workloadIdentity and store it alongside the cached rest.Config. The cache is now only considered valid when both the hash matches the current spec and it isn't near expiry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getWorkloadIdentityRestConfig caches the built rest.Config per cluster in an in-memory wiCache, keyed only by namespace/name. Eviction is only wired up in each component's SveltosCluster delete handler nothing invalidates the cache on update. So editing spec.workloadIdentity had no effect until the cached cloud token neared its natural expiry
The fix consist in hashing spec.workloadIdentity and store it alongside the cached rest.Config. The cache is now only considered valid when both the hash matches the current spec and it isn't near expiry