Add per-cluster deployment health signals (hasIssues, isProvisioning)#167
Merged
Merged
Conversation
The /capiclusters and /sveltosclusters endpoints now include two new boolean fields on each cluster: - hasIssues — true when at least one ClusterSummary has a feature in Failed or FailedNonRetriable state, or in Provisioning state with a non-empty failure message. The latter covers the Sveltos retry cycle where a retriable error moves status back to Provisioning without clearing the failure message; the message is only reset when the feature reaches Provisioned. - isProvisioning — true when at least one ClusterSummary is actively deploying (clean Provisioning with no failure message) or waiting for a dependency (status.dependencies non-empty). Always false when hasIssues is true, so the two signals are mutually exclusive from the consumer's perspective. Both signals are maintained as secondary in-memory indexes (clusterWithIssues and clusterProvisioning, each a map[string]*libsveltosset.Set) updated by the existing ClusterSummary watcher. No per-request scanning — each cluster lookup is O(1). Entries are created lazily and deleted when the set empties, keeping memory cost proportional to clusters with active state rather than total ClusterSummary count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /capiclusters and /sveltosclusters endpoints now include two new boolean fields on each cluster:
Both signals are maintained as secondary in-memory indexes (clusterWithIssues and clusterProvisioning, each a map[string]*libsveltosset.Set) updated by the existing ClusterSummary watcher. No per-request scanning — each cluster lookup is O(1). Entries are created lazily and deleted when the set empties, keeping memory cost proportional to clusters with active state rather than total ClusterSummary count.