Skip to content

add test for SELEventsCollector#228

Draft
kmlebedev wants to merge 2 commits into
prometheus-community:masterfrom
kmlebedev:test_sel_env_collect
Draft

add test for SELEventsCollector#228
kmlebedev wants to merge 2 commits into
prometheus-community:masterfrom
kmlebedev:test_sel_env_collect

Conversation

@kmlebedev

@kmlebedev kmlebedev commented Dec 9, 2024

Copy link
Copy Markdown
go test -v
=== RUN   TestCollectSELEventsCollector
--- PASS: TestCollectSELEventsCollector (0.00s)
PASS
ok      github.com/prometheus-community/ipmi_exporter   0.397s

@bitfehler

Copy link
Copy Markdown
Contributor

Thank you for your PR. Is there a specific reason you are wanting to test this? I am somewhat hesitant, because this would be mocking input where can't make any assertions about its format anyways (because parts of it are vendor-specifc, so all bets are off). I could maybe see how this might be useful to collect weird edge cases observed in the wild. Is there where this was going? If so, I'd be curious to hear about those first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants