Skip to content

Remove chrome lightouse #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luciopalmieri wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove chrome lightouse #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5feacbe
changed content length management
gardocki Jul 30, 2020
3ce0b56
added env as third parameter
gardocki Aug 21, 2020
99ac7cc
added chrome lighthouse
gardocki Sep 1, 2020
d52922f
Update prerender_rails.rb
gardocki Nov 26, 2020
0c2e141
[WP-2946] Remove agent Chrome-Lighthouse from bots
luciopalmieri Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec/reports
test/tmp
test/version_tmp
tmp
.idea
17 changes: 12 additions & 5 deletions lib/prerender_rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ def initialize(app, options={})
'nuzzel',
'Discordbot',
'Google Page Speed',
'Qwantify'
'Qwantify',
#'Chrome-Lighthouse', # Removed to test Web Vitals without prerendering
'SemrushBot',
'AhrefsSiteAudit'
]

@extensions_to_ignore = [
Expand Down Expand Up @@ -105,7 +108,7 @@ def call(env)
prerendered_response = get_prerendered_page_response(env,use_second_service)

if prerendered_response
response = build_rack_response_from_prerender(prerendered_response)
response = build_rack_response_from_prerender(prerendered_response, env)
after_render(env, prerendered_response)
return response.finish
end
Expand Down Expand Up @@ -221,10 +224,14 @@ def get_prerender_service_url use_second_service
end


def build_rack_response_from_prerender(prerendered_response)
response = Rack::Response.new(prerendered_response.body, prerendered_response.code, prerendered_response.header)
def build_rack_response_from_prerender(prerendered_response, env)
header = prerendered_response.header

@options[:build_rack_response_from_prerender].call(response, prerendered_response) if @options[:build_rack_response_from_prerender]
header['Content-Length'] = prerendered_response.body.length

response = Rack::Response.new(prerendered_response.body, prerendered_response.code, header)

@options[:build_rack_response_from_prerender].call(response, prerendered_response, env) if @options[:build_rack_response_from_prerender]

response
end
Expand Down