PROE-5647: Speed up ps-agent builds - use pre-built wheels from GitHub Releases#1
PROE-5647: Speed up ps-agent builds - use pre-built wheels from GitHub Releases#1
Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
| - name: Verify wheel | ||
| run: | | ||
| pip install --no-deps dist/*.whl | ||
| python -c "from mitmproxy.version import VERSION; print(f'Built version: {VERSION}')" |
There was a problem hiding this comment.
The python -c "from mitmproxy.version import VERSION; print(...)" step only prints the baked VERSION and never checks it against ${{ github.ref_name }} before uploading dist/*.whl; should we fail the job when they differ?
Finding type: Logical Bugs | Severity: 🟢 Low
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
.github/workflows/ps-build-release.yml around lines 30-33 in the “Verify wheel”
step, add a validation that compares the imported mitmproxy.version.VERSION to the
GitHub release tag (github.ref_name). Refactor the one-liner so it exits with a non-zero
status when VERSION != github.ref_name, and keep the printed output for logging. This
will prevent uploading dist/*.whl when the embedded package version does not match the
release tag.
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enable the release workflow to build mitmproxy wheel artifacts, verify them, and publish them via GitHub Releases so ps-agent can install prebuilt packages instead of compiling from source. Update the forked mitmproxy version metadata to advertise the patched release that agents will consume.
Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(0)