Skip to content

PROE-5647: Speed up ps-agent builds - use pre-built wheels from GitHub Releases#1

Open
vitaly-ps wants to merge 3 commits intops-patchfrom
vitaly_optimize_build
Open

PROE-5647: Speed up ps-agent builds - use pre-built wheels from GitHub Releases#1
vitaly-ps wants to merge 3 commits intops-patchfrom
vitaly_optimize_build

Conversation

@vitaly-ps
Copy link
Copy Markdown

@vitaly-ps vitaly-ps commented Apr 24, 2026

Generated description

Below is a concise technical summary of the changes proposed in this PR:
Enable the release workflow to build mitmproxy wheel artifacts, verify them, and publish them via GitHub Releases so ps-agent can install prebuilt packages instead of compiling from source. Update the forked mitmproxy version metadata to advertise the patched release that agents will consume.

TopicDetails
Version metadata Align the forked mitmproxy version identifier with the patched build so agents clearly reference the ps-agent-specific dependency.
Modified files (1)
  • mitmproxy/version.py
Latest Contributors(2)
UserCommitDate
noreply@mitmproxy.orgreopen main for develo...November 24, 2025
git@maximilianhils.comtls_version: QUIC -> Q...September 21, 2024
Release workflow Enable the GitHub release workflow to build, validate, and publish mitmproxy wheel artifacts for prompt-security targets, allowing downstream agent builds to download prebuilt binaries.
Modified files (1)
  • .github/workflows/ps-build-release.yml
Latest Contributors(0)
UserCommitDate
This pull request is reviewed by Baz. Review like a pro on (Baz).

@notion-workspace
Copy link
Copy Markdown

@autofix-troubleshooter
Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Comment on lines +30 to +33
- name: Verify wheel
run: |
pip install --no-deps dist/*.whl
python -c "from mitmproxy.version import VERSION; print(f'Built version: {VERSION}')"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python -c "from mitmproxy.version import VERSION; print(...)" step only prints the baked VERSION and never checks it against ${{ github.ref_name }} before uploading dist/*.whl; should we fail the job when they differ?

Finding type: Logical Bugs | Severity: 🟢 Low


Want Baz to fix this for you? Activate Fixer

Other fix methods

Fix in Cursor

Prompt for AI Agents:

Before applying, verify this suggestion against the current code. In
.github/workflows/ps-build-release.yml around lines 30-33 in the “Verify wheel”
step, add a validation that compares the imported mitmproxy.version.VERSION to the
GitHub release tag (github.ref_name). Refactor the one-liner so it exits with a non-zero
status when VERSION != github.ref_name, and keep the printed output for logging. This
will prevent uploading dist/*.whl when the embedded package version does not match the
release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants