Fix #418: Clean up temp directories when git clone fails #421
+224
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comprehensive unit and E2E tests that detect the resource leak bug where temp directories are not cleaned up when git clone fails in _setup_repository(). Unit tests (tests/test_agentic_change_issue_418.py): - Test cleanup on clone failure (non-zero exit code) - Test cleanup on subprocess exception - Regression test for successful clones - Test accumulation of leaked directories E2E tests (tests/test_e2e_issue_418.py): - Test real clone failures with non-existent repos - Test subprocess exceptions - Regression test for successful operations - Integration test for cumulative leak impact Tests currently fail, demonstrating the bug. They will pass once the fix is implemented. Related to promptdriven#418 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixes promptdriven#418 Added shutil.rmtree() cleanup in both failure paths: - When git clone returns non-zero exit code (line 128) - When subprocess.run raises an exception (line 131) This prevents disk space leaks from accumulated temp directories when clone operations fail due to network issues, auth failures, or other errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Serhan-Asad
changed the title
Reduced test verbosity: - Removed excessive comments and documentation - Consolidated redundant test cases - Reduced from 8 tests to 5 essential tests - 78% reduction in test code (985 -> 218 lines) Tests still cover all critical paths: - Clone failure cleanup (non-zero exit) - Exception cleanup - Success case (regression)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a resource leak where temporary directories created during repository setup were not cleaned up when git clone operations failed. The fix adds shutil.rmtree() calls to both exception handlers in the _setup_repository() function to ensure cleanup occurs on clone failures.
Changes:
- Added temp directory cleanup on non-zero exit code from git clone
- Added temp directory cleanup when subprocess.run raises an exception
- Added comprehensive unit and E2E tests to verify cleanup behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pdd/agentic_change.py | Added shutil.rmtree() calls in both failure paths (lines 128, 131) to clean up temp directories |
| tests/test_agentic_change_issue_418.py | Added unit tests verifying cleanup on failure and proper retention on success |
| tests/test_e2e_issue_418.py | Added E2E tests for temp directory leak prevention and success case validation |
| prompts | Removed symlink to pdd/prompts directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace ignore_errors=True with explicit error handling that: - Attempts cleanup with shutil.rmtree() - Catches and logs cleanup failures to stderr - Allows diagnosis of permission issues and other problems - Doesn't interrupt the main error flow This addresses the Copilot review comments about silently hiding legitimate errors during cleanup (e.g., permission issues).
Contributor
Author
|
Addressed Copilot review comments (lines 128 & 131) Fixed in commit 837dd85. Changes:
Testing:
|
Contributor
Author
|
Copilot review comments addressed: Both comments on lines 128 & 131 have been fixed in commit 837dd85:
The cleanup now properly handles and reports errors while still ensuring temp directories are removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes resource leak where temporary directories created during repository setup are not cleaned up when git clone operations fail.
Changes
File:
pdd/agentic_change.py(lines 128, 131)Added
shutil.rmtree(temp_dir, ignore_errors=True)cleanup in both failure paths:Root Cause
The
_setup_repository()function created a temporary directory withtempfile.mkdtemp()on line 112, but failed to clean it up whengit clonefailed. The exception handlers raisedRuntimeErrorwithout callingshutil.rmtree(temp_dir), leaving orphaned directories on disk.Test Results
✅ All tests passing
tests/test_agentic_change_issue_418.py)tests/test_e2e_issue_418.py)Test Coverage
Impact
This fix prevents disk space leaks from accumulated temp directories when clone operations fail due to:
Fixes #418
Generated by PDD agentic workflow (bug + fix)