Add failing tests for #437: null hash fields in fingerprint metadata #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata This commit adds comprehensive test coverage to detect the bug where fingerprint metadata files have all hash fields set to null instead of containing actual content hashes. Test files added: - Unit test in tests/test_operation_log.py: Tests the @log_operation decorator to verify it creates fingerprints with null hashes when the 'paths' parameter is not passed to save_fingerprint() - E2E test in tests/test_e2e_issue_437_null_hashes.py: Tests the full 'pdd generate' command flow to verify the bug at integration level Both tests are verified to fail on the current codebase and will pass once the fix is implemented. Root cause: pdd/operation_log.py:338 - @log_operation decorator calls save_fingerprint() without the required 'paths' parameter. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing tests that detect the bug reported in #437 where fingerprint metadata files have all hash fields set to
nullinstead of containing actual content hashes.Test Files
tests/test_operation_log.py(modified)tests/test_e2e_issue_437_null_hashes.py(new)What This PR Contains
test_log_operation_decorator_null_hashes_bug_issue_437) that reproduces the reported bug by testing the@log_operationdecorator directlytest_e2e_issue_437_null_hashes_fullandtest_e2e_issue_437_null_hashes_minimal) that verifies the bug at integration level using the actualpdd generateCLI commandRoot Cause
The
@log_operationdecorator at line 338 ofpdd/operation_log.pycallssave_fingerprint()without the requiredpathsparameter. Without this parameter,calculate_current_hashes()returns an empty dictionary, causing all hash fields (prompt_hash,code_hash,example_hash,test_hash) to be set toNonein the fingerprint metadata files.This breaks the fingerprint-based change detection feature that is core to PDD's incremental regeneration system.
Next Steps
pdd/operation_log.py:338Fixes #437
Generated by PDD agentic bug workflow