Skip to content

feat(torghut): add consumer evidence contract canaries#6727

Open
gregkonush wants to merge 1 commit into
mainfrom
codex/swarm-torghut-quant
Open

feat(torghut): add consumer evidence contract canaries#6727
gregkonush wants to merge 1 commit into
mainfrom
codex/swarm-torghut-quant

Conversation

@gregkonush
Copy link
Copy Markdown
Member

@gregkonush gregkonush commented May 15, 2026

Summary

  • Added torghut.consumer-evidence-contract-canary.v1 compact refs to /trading/consumer-evidence?view=summary for route_warrant_exchange and repair_bid_settlement_ledger, while keeping full contract bodies on the full route.
  • Updated Jangar Torghut evidence normalization to consume compact refs first, fall back to one bounded full consumer-evidence fetch when refs are absent, and report torghut_contract_transport_unavailable instead of false missing-contract blockers when that fallback fails.
  • Split the Jangar resolver contract and transport helpers into focused modules so the production path stays under the module-size guardrail.
  • Updated source-serving verdict behavior and tests so compact route-warrant and repair-bid refs satisfy required source-serving contract presence for zero-notional repair-only evidence.
  • Documented design provenance, validation, rollout risk, rollback, and live revenue-repair before/after evidence in docs/torghut/rollouts/2026-05-15-consumer-evidence-contract-canary.md.

Design provenance:

  • docs/torghut/design-system/v6/213-torghut-consumer-evidence-contract-canary-and-alpha-reentry-transport-2026-05-15.md
  • docs/agents/designs/207-jangar-consumer-evidence-transport-split-and-source-serving-contract-canary-2026-05-15.md

Runtime evidence:

  • Before local implementation: /trading/revenue-repair reported business_state=repair_only, revenue_ready=false, top queue item repair_alpha_readiness, affected value gate routeable_candidate_count, accepted_routeable_candidate_count=0, and max_notional=0.
  • After local implementation and before deployment: /trading/revenue-repair still reports business_state=repair_only, revenue_ready=false, top queue item repair_alpha_readiness, affected value gate routeable_candidate_count, accepted_routeable_candidate_count=0, and max_notional=0.
  • Expected first revenue impact is retiring false source-serving transport debt; this PR does not enable live submission or widen notional.

Related Issues

None

Testing

  • PASS uv sync --frozen --extra dev
  • PASS uv run --frozen ruff check app/main.py app/trading/consumer_evidence.py tests/test_consumer_evidence.py tests/test_trading_api.py
  • PASS uv run --frozen ruff format --check app/main.py app/trading/consumer_evidence.py tests/test_consumer_evidence.py tests/test_trading_api.py
  • PASS uv run --frozen pytest tests/test_consumer_evidence.py
  • PASS uv run --frozen pytest tests/test_trading_api.py -k consumer_evidence
  • PASS uv run --frozen pytest tests/test_consumer_evidence.py tests/test_trading_api.py -k consumer_evidence
  • PASS uv run --frozen pytest tests/test_no_delta_repair_reentry_auction.py
  • PASS uv run --frozen pyright --project pyrightconfig.json
  • PASS uv run --frozen pyright --project pyrightconfig.alpha.json
  • PASS uv run --frozen pyright --project pyrightconfig.scripts.json
  • PASS bunx oxfmt --check services/jangar/README.md services/torghut/README.md docs/torghut/rollouts/2026-05-15-consumer-evidence-contract-canary.md services/jangar/src/routes/ready.test.ts services/jangar/src/server/control-plane-torghut-consumer-evidence.ts services/jangar/src/server/control-plane-source-serving-contract-verdict.ts services/jangar/src/server/__tests__/control-plane-torghut-consumer-evidence.test.ts services/jangar/src/server/__tests__/control-plane-source-serving-contract-verdict.test.ts
  • PASS bunx oxfmt --check services/jangar packages/scripts/src/jangar argocd/applications/jangar
  • PASS bunx oxlint --config .oxlintrc.json services/jangar/src/routes/ready.test.ts services/jangar/src/server/control-plane-torghut-consumer-evidence.ts services/jangar/src/server/control-plane-source-serving-contract-verdict.ts services/jangar/src/server/__tests__/control-plane-torghut-consumer-evidence.test.ts services/jangar/src/server/__tests__/control-plane-source-serving-contract-verdict.test.ts
  • PASS bun run --cwd services/jangar lint:oxlint
  • PASS bun run --cwd services/jangar lint:oxlint:type
  • PASS bun run --cwd services/jangar docs:inventory:check
  • PASS bun run --cwd services/jangar check:module-sizes
  • PASS bun run --filter @proompteng/otel build
  • PASS bun run --filter @proompteng/temporal-bun-sdk build
  • PASS bun run --filter @proompteng/jangar tsc
  • PASS bunx tsc --noEmit --project tsconfig.paths.json
  • PASS bunx vitest run --config vitest.config.ts src/server/__tests__/control-plane-torghut-consumer-evidence.test.ts src/server/__tests__/control-plane-source-serving-contract-verdict.test.ts
  • PASS bun run --filter @proompteng/jangar test
  • PASS bun run --cwd services/jangar build
  • PASS git diff --check
  • PASS curl -fsS http://torghut.torghut.svc.cluster.local/trading/revenue-repair | jq '{business_state, revenue_ready, max_notional, top_repair_queue_item: .repair_queue[0], selected_value_gate, accepted_routeable_candidate_count, zero_notional_or_stale_evidence_rate}'
  • PASS gh pr checks 6727 --repo proompteng/lab

Screenshots (if applicable)

N/A

Breaking Changes

None. The summary canary is additive, full consumer evidence remains authoritative for complete contract bodies, and Jangar falls back to full evidence when compact refs are missing.

Rollback path: revert this PR or have Jangar ignore contract_canary_refs and return source-serving verdicts to full-payload authority. Torghut max_notional=0, repair-only state, and live-submit gates remain unchanged.

Checklist

  • Testing section documents the exact validation performed (or N/A with justification).
  • Screenshots and Breaking Changes sections are handled appropriately (removed or filled in).
  • Documentation, release notes, and follow-ups are updated or tracked.

@gregkonush
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
Copy link
Copy Markdown
Member Author

gregkonush commented May 15, 2026

Current status: PR #6727 is open, mergeable, non-draft, and green for codex/swarm-torghut-quant at 102f820ec.

What changed:

  • Torghut summary consumer evidence now emits torghut.consumer-evidence-contract-canary.v1 compact refs for route_warrant_exchange and repair_bid_settlement_ledger.
  • Jangar consumes compact refs first, falls back to one bounded full consumer-evidence fetch when refs are absent, and reports torghut_contract_transport_unavailable instead of false missing-contract blockers when full transport fails.
  • Jangar contract and transport helpers are split out of the resolver; control-plane-torghut-consumer-evidence.ts is now 792 lines and below the CI module-size guardrail.
  • Source-serving verdicts infer required contracts from compact route-warrant and repair-bid refs while keeping dispatch repair zero-notional and all live submission gates unchanged.
  • Rollout evidence and rollback notes are in docs/torghut/rollouts/2026-05-15-consumer-evidence-contract-canary.md.

Runtime evidence:

  • Live /trading/revenue-repair before and after local implementation: business_state=repair_only, revenue_ready=false, top queue item repair_alpha_readiness, affected value gate routeable_candidate_count, accepted_routeable_candidate_count=0, max_notional=0.
  • Revenue impact expected from this PR: retire false source-serving transport debt. It does not enable paper/live submission or widen notional.

Local validation after rebasing onto origin/main and fixing the Jangar module-size CI failure:

  • PASS uv run --frozen ruff check app/main.py app/trading/consumer_evidence.py tests/test_consumer_evidence.py tests/test_trading_api.py
  • PASS uv run --frozen pytest tests/test_consumer_evidence.py tests/test_trading_api.py -k consumer_evidence
  • PASS uv run --frozen pytest tests/test_no_delta_repair_reentry_auction.py
  • PASS all three Torghut Pyright profiles
  • PASS Jangar Oxfmt/Oxlint on touched files
  • PASS bun run --cwd services/jangar lint:oxlint
  • PASS bun run --cwd services/jangar lint:oxlint:type
  • PASS bun run --cwd services/jangar docs:inventory:check
  • PASS bun run --cwd services/jangar check:module-sizes
  • PASS bun run --filter @proompteng/jangar tsc
  • PASS bunx tsc --noEmit --project tsconfig.paths.json
  • PASS focused Jangar Vitest for the changed resolver/verdict tests
  • PASS full bun run --filter @proompteng/jangar test with 199 files / 1261 tests
  • PASS bun run --cwd services/jangar build

GitHub CI:

  • PASS gh pr checks 6727 --repo proompteng/lab
  • Merge state: CLEAN; draft state: false.

Next action: deployer handoff after merge; rollout verification must prove image promotion, Argo sync, live service health, and /trading/revenue-repair status before claiming runtime revenue impact.

@gregkonush gregkonush force-pushed the codex/swarm-torghut-quant branch from fa9f515 to 102f820 Compare May 15, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant