Change how Apply works#54
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 78 78
Lines 5126 4811 -315
==========================================
- Hits 5126 4811 -315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a significant change that removes teh output argument from the Apply signature in favor of returning a type that is always the same type as the validator. This significant reduces code complexity since rule sets no longer need to worry about output being unknown at compile time. As of this change, ProtoValidate can no longer be used to mutate between two data types, which was never the goal anyway, but it is now much easier to develop for and debug.
andrewcurioso
force-pushed
the
feature/apply-refactor
branch
from
aa14ea3 to
0b8cff9
Compare
andrewcurioso
force-pushed
the
feature/apply-refactor
branch
from
0b8cff9 to
54975b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a significant change that removes the output argument from the Apply signature in favor of returning a type that is always the same type as the validator.
The old signature:
The new one:
This significant reduces code complexity since rule sets no longer need to worry about output being unknown at compile time.
As of this change, ProtoValidate can no longer be used to mutate between two data types, which was never the goal anyway, but it is now much easier to develop for and debug.