Fix compact control foregrounds#5
Merged
Merged
Conversation
brxs
marked this pull request as ready for review
July 19, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
text-signaltypography utility from the semantic gold signal colortext-brand-signal@protocol-works/design-tokens@0.2.1and@protocol-works/ui@0.3.2, with the UI package requiring the corrected token baselineWhy
The Tailwind theme exposed both a
--text-signalfont-size token and a--color-signalcolor token. Tailwind resolvedtext-signalas the color utility, so compact Fields, Inputs, Textareas, Buttons, and related controls inherited gold instead of receiving the intended 13px type size.Impact
Ordinary compact controls render with their contextual black/white foreground again. Gold remains available only when a consumer explicitly requests the brand signal color.
Verification
npm run checknpm pack --dry-runnpm pack --dry-run --workspace @protocol-works/ui.text-signalcontainsfont-sizeand no signalcolor