Skip to content

Fix compact control foregrounds#5

Merged
brxs merged 1 commit into
mainfrom
codex/neutral-control-foregrounds
Jul 19, 2026
Merged

Fix compact control foregrounds#5
brxs merged 1 commit into
mainfrom
codex/neutral-control-foregrounds

Conversation

@brxs

@brxs brxs commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

What changed

  • separates the compact text-signal typography utility from the semantic gold signal color
  • exposes gold explicitly as text-brand-signal
  • adds regression coverage for both the token package and installed UI consumer CSS
  • prepares @protocol-works/design-tokens@0.2.1 and @protocol-works/ui@0.3.2, with the UI package requiring the corrected token baseline

Why

The Tailwind theme exposed both a --text-signal font-size token and a --color-signal color token. Tailwind resolved text-signal as the color utility, so compact Fields, Inputs, Textareas, Buttons, and related controls inherited gold instead of receiving the intended 13px type size.

Impact

Ordinary compact controls render with their contextual black/white foreground again. Gold remains available only when a consumer explicitly requests the brand signal color.

Verification

  • npm run check
  • npm pack --dry-run
  • npm pack --dry-run --workspace @protocol-works/ui
  • verified generated .text-signal contains font-size and no signal color
  • verified both packages contain the intended release files

@brxs
brxs marked this pull request as ready for review July 19, 2026 16:11
@brxs
brxs merged commit 4811777 into main Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant