Conversation
feat: optimization, tests, vehicle information methods, QOL Optimization: initially, the VIN key component would always have be recreated with every call to a vehicle information method. the as_key() method has been optimized and a key_cache field has been added to VIN using OnceCell. this allowed us to have the key as a &str and quickly pass it to other functions. Features: add several new vehicle information retrieval methods to VIN. OQL: a new method 'vpic_connection()' has been added to ease of use. previously, everytime a reference for the sqlite::Connection needed to be stored, a match statement would always match self.vpic_db_con with Ok mapping Err to VinError::VPICNoConnection. instead, a simple call to vpic_connection will return a Result<&sqlite::Connection, VinError> and returns self.vpic_db_con as_ref. the VIN constructor, 'new()' has been changed to accept &str. instead of having the user convert the parameters to a String manuaully, it does this automatically in the new() method using Into<>. Tests: added tests for cylinder_count, engine_model. also modified GitHub workflow to download the sqlite database from GitHub lfs when running cargo test to stop the workflows from failing. ran and appended all changes from cargo clippy.
…ation data like airbags, abs, etc
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIN branch is ready to be merged to main. Very detailed pull request message.