Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive JSON mapping samples and example code for the CBOE implementation, demonstrating various transformation scenarios between different message formats (MX, MT, and JSON).
- Adds four new sample text files documenting input/output examples for mx2json, mt2json, json2mx, and json2mt transformations
- Implements 16 Java example classes demonstrating different mapping scenarios including simple mappings, relative paths, foreach operations, and sequences
- Removes the legacy Mt2JsonExample.java class and replaces it with more focused example implementations
Reviewed Changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mx2json_samples.txt | Documents MX to JSON transformation examples across different sheet configurations (SIMPLE, RELATIVE, FOREACH, FOREACH_REL) |
| mt2json_samples.txt | Provides MT to JSON transformation sample with a SIMPLE sheet example |
| json2mx_samples.txt | Shows JSON to MX transformation examples with various mapping patterns (SIMPLE, PATH, REPLICATED, REP_VALUESET) |
| json2mt_samples.txt | Demonstrates JSON to MT transformation samples covering different scenarios (SIMPLE, INDEX, SEQUENCE, REP_SEQ) |
| Mx2JsonExample1-4.java | Four example classes demonstrating different MX to JSON transformation scenarios |
| Mt2JsonExample1.java | Replaces old Mt2JsonExample with focused implementation |
| Json2MxExample1-4.java | Four example classes for JSON to MX transformations |
| Json2MtExample1-4.java | Four example classes for JSON to MT transformations |
| Mt2JsonExample.java | Legacy example removed in favor of new focused implementations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.