[codex] Preserve combobox search on selection#19
Merged
munezaclovis merged 4 commits intoJun 10, 2026
Conversation
c6ed8ae to
52c3af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
selectOption()resetsearchQuery, cleared the input value, and restoredoriginalOptionsfor every single-select selection. That made dynamic and filtered results disappear immediately after clicking an option.Automation Note
The fork has a
Fix PHP Code Stylingworkflow that runs on any PHP push and auto-commits Pint changes. After the combobox test change was pushed, that workflow added aFix stylingcommit for existing Pint differences in three workbench/test files. The functional combobox change itself is inresources/js/components/combobox.js,resources/dist/components/combobox.js, andtests/Browser/ComboboxTest.php.Validation
node bin/build.jsvendor/bin/testbench filament:assets --no-interactionhttp://127.0.0.1:8000/admin/posts/create:statussearch forpubkeepspub, keeps onlyPublished, and marks it selected after clickcategory_idsearch forTechkeepsTech, keepsTechnology, and marks it selected after clickvendor/bin/pint --dirtyphp -l tests/Browser/ComboboxTest.php && php -l src/Components/Combobox.phpFocused Pest browser tests could not run locally because this checkout's lock/vendor state is inconsistent:
composer.jsonrequirespestphp/pest-plugin-browser, butcomposer.lockdoes not include it, andcomposer installexits before installing dependencies.