MacOS fix#59
Merged
Merged
Conversation
Contributor
|
Thanks! I donno why macOS brew moved lld to a different path, it kinda defeats the purpose of llvm-config. Anyhow, I will merge this as soon as I get back home. |
Contributor
|
I made some minor cosmetic changes to master after merging this, please let me know if I screwed something up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have moved all duplicated code to common file which is included from several makefiles and fixed the issue with Homebrew's ld which is moved out of llvm to its own lld package. Now it compiles properly on MacOS.