Fix invalid escape sequence SyntaxWarnings#66
Merged
Conversation
The two ASCII-art literals and the parse_multi_value_header() regex used unrecognized escape sequences (\_, \ , \s), which emit a SyntaxWarning on Python 3.12+ (DeprecationWarning earlier) and will become a SyntaxError in a future Python. Make them raw strings; the rendered art and regex behaviour are byte-for-byte unchanged (verified against the prior values). Adds a regression test that compiles every module in the httpbin package with escape-sequence warnings escalated to errors. Closes #62. Supersedes #55. Co-Authored-By: gesh <gesh@gesh.uni.cx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two ASCII-art string literals and the
parse_multi_value_header()regex use unrecognized escape sequences (\_,\,\s). These emit aSyntaxWarningon Python 3.12+ (aDeprecationWarningbefore that) and will become aSyntaxErrorin a future Python. Closes #62.parse_multi_value_headeroutput before/after.httpbinpackage with escape-sequence warnings escalated to errors (fails on the old code, passes on the fix).Based on #55 (@gesh / hseg), itself a rebase of postmanlabs#646, with a regression test added. Supersedes #55.