change auth strategy from warden to Azure AD UMGs#257
change auth strategy from warden to Azure AD UMGs#257Alex Kiessling (ajkiessl) merged 9 commits intomainfrom
Conversation
…require_login to auto_login and use a view with a little JS to login
…odifues mocked authentication to use ClimateControl for setting ENV variables. Converts gui_auth_spec from warden tests, to new session controller authentication. Moves sidekiq_access_spec to /admin and fixes those to work with new auth. Fixes AuthHelper for logging in to redirect to the callback url which triggers the session creation
|
Jesse LE (@jlandiseigsti) This is done and ready for review. Some of the things I did:
|
Jesse LE (jlandiseigsti)
left a comment
There was a problem hiding this comment.
Every thing looks good to me.
Are we going to implement logout separately?
|
|
||
| get '/auth/azure_oauth/callback', to: 'sessions#create' | ||
| get '/auth/failure', to: 'sessions#failure' | ||
| delete '/logout', to: 'sessions#destroy' |
There was a problem hiding this comment.
Is this connected to anything at the moment?
There was a problem hiding this comment.
The RailsAdmin UI actually has a link in the top right to log out. That hooks into this route. I think that's just a default for RailsAdmin, though. We could implement a logout button in the future, but I think we'd need a neutral landing page for that. Everything is behind auth, so you'd just get logged back in after logging out.
There was a problem hiding this comment.
It would be pretty simple to remove the auto login stuff, and replace it with login and log out buttons, though. Most of our other apps do that. But I'm curious to see how the auto login works.
Fixes #228
I wasn't quite able to wrap this up, but it's mostly there. Everything works locally, new authorized users and admin umg groups have been created, & the feature specs are fixed.
To be completed:
add remainder of authorized users (currently just has dev team, Binky, & Justin, I was waiting for everything to be wrapped up before adding remaining users)Moved here: Release tasks #266